test: add common.crashOnUnhandledRejection()#17212
Closed
Scya597 wants to merge 1 commit intonodejs:masterfrom
Closed
test: add common.crashOnUnhandledRejection()#17212Scya597 wants to merge 1 commit intonodejs:masterfrom
Scya597 wants to merge 1 commit intonodejs:masterfrom
Conversation
also add comment in test/parallel/test-http2-client-promisify-connect.js
MylesBorins
previously requested changes
Nov 22, 2017
| const common = require('../common'); | ||
| common.crashOnUnhandledRejection(); | ||
|
|
||
| // Crash the process on unhandled rejections. |
Contributor
There was a problem hiding this comment.
I don't think that this comment is necessary, can you please remove it
cjihrig
approved these changes
Nov 22, 2017
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with comment removed.
jasnell
approved these changes
Nov 22, 2017
Member
Member
|
CI failure on alpine linux appears unrelated. |
Member
|
I'll be fixing @MylesBorins' nit on landing. |
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
PR-URL: #17212 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in f7c8d23 with the comment removed and commit message slightly updated. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17212 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17212 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17212 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17212 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add comment in test/parallel/test-http2-client-promisify-connect.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes(https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)
Affected core subsystem(s)