test: increase coverage for http2 response headers#15035
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
test: increase coverage for http2 response headers#15035apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. Refs: nodejs#14985
cjihrig
approved these changes
Aug 25, 2017
jasnell
approved these changes
Aug 25, 2017
Member
TimothyGu
approved these changes
Aug 26, 2017
BridgeAR
approved these changes
Aug 29, 2017
Member
|
Landed in 3eb0297 @apapirovski thanks for your contribution and congratulations on your first commit to Node.js! |
BridgeAR
pushed a commit
that referenced
this pull request
Aug 29, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: #15035 Refs: #14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: nodejs/node#15035 Refs: nodejs/node#14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: nodejs/node#15035 Refs: nodejs/node#14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: nodejs#15035 Refs: nodejs#14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: #15035 Refs: #14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just :status. PR-URL: #15035 Refs: #14985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded an existing test for setting pseudo-headers on response to include all pseudo-headers, not just
:status. This is a part of the request for increasing coverage for http2 as per #14985This is my first pull request for this project but I'm hoping to continue working on additional tests for h2, so if there's any feedback I would love to hear it and incorporate it. Thanks!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test