errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error#15003
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-rm-dup-error
Closed
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error#15003maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-rm-dup-error
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-rm-dup-error
Conversation
Trott
approved these changes
Aug 24, 2017
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI runs without incident.
I believe we try to keep those codes in alphabetical order, so maybe while you're in there, move the nearby ERR_HTTP_TRAILER_INVALID to the right place?
danbev
approved these changes
Aug 24, 2017
Contributor
Author
|
@Trott yep, was planning on opening up an issue to grab feedback about keeping the errors in alphabetical order, and also making sure the docs are in sync with the list of errors, there are a bunch of discrepancies right now 😞 |
Member
Awesome. Thanks for doing the work of identifying the issues and correcting them! |
lpinca
approved these changes
Aug 24, 2017
hiroppy
approved these changes
Aug 24, 2017
cjihrig
approved these changes
Aug 24, 2017
jasnell
approved these changes
Aug 24, 2017
hiroppy
pushed a commit
to hiroppy/node
that referenced
this pull request
Aug 27, 2017
PR-URL: nodejs#15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
landed in 0097794 |
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
PR-URL: #15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #15003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fairly self-explanatory, but there are two listings of
ERR_HTTP_INVALID_STATUS_CODEinlib/internal/errors.js, so one needed to be removed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors