test: remove erroneous assert message from test#14918
Closed
BethGriggs wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove erroneous assert message from test#14918BethGriggs wants to merge 1 commit intonodejs:masterfrom
BethGriggs wants to merge 1 commit intonodejs:masterfrom
Conversation
Removes the incorrect 'exit successfully' message from test when the exit code is 0.
Contributor
cjihrig
approved these changes
Aug 18, 2017
Trott
approved these changes
Aug 18, 2017
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM. There are a lot of places in our tests where the assertion message is the opposite of what it seems like it should be. The messages rarely improve the output anyway.
Member
|
CI failures look like things that need legitimate investigation, but are unrelated to this change. |
jasnell
approved these changes
Aug 18, 2017
tniessen
approved these changes
Aug 18, 2017
refack
approved these changes
Aug 18, 2017
lpinca
approved these changes
Aug 19, 2017
Member
|
Landed in b9d63ab, thank you! |
tniessen
pushed a commit
that referenced
this pull request
Aug 20, 2017
Removes the incorrect 'exit successfully' message from test when the exit code is 0. PR-URL: #14918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Removes the incorrect 'exit successfully' message from test when the exit code is 0. PR-URL: #14918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Removes the incorrect 'exit successfully' message from test when the exit code is 0. PR-URL: #14918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the incorrect 'exit successfully' message from test when the
exit code is 0.
We expect the exit code to be 0, so when it fails it should say 'exit unsuccessful'. Adding a message will hide the exit code from the error, so IMO we should remove the message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test