Closed
Conversation
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options
cjihrig
approved these changes
Jul 25, 2017
jasnell
approved these changes
Jul 25, 2017
Fishrock123
approved these changes
Jul 25, 2017
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 27, 2017
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options PR-URL: nodejs#14464 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Member
Author
|
Landed in d3e07e3 |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options PR-URL: #14464 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeoption to reduce combinations of benchmarks run (savesabout 15% on run duration of test on my local machine)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark timers