[v8.x] n-api: add code parameter to error helpers#14453
Closed
addaleax wants to merge 2 commits intonodejs:v8.x-stagingfrom
Closed
[v8.x] n-api: add code parameter to error helpers#14453addaleax wants to merge 2 commits intonodejs:v8.x-stagingfrom
addaleax wants to merge 2 commits intonodejs:v8.x-stagingfrom
Conversation
In support of the effort to add error codes to all errors generated by Node.js, add an optional code parameter to the helper functions used to throw/create errors in N-API. PR-URL: nodejs#13988 Fixes: nodejs#13933 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
To make backporting easier.
Member
Author
jasnell
approved these changes
Jul 24, 2017
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 27, 2017
In support of the effort to add error codes to all errors generated by Node.js, add an optional code parameter to the helper functions used to throw/create errors in N-API. Backport-PR-URL: nodejs#14453 Backport-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#13988 Fixes: nodejs#13933 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 27, 2017
To make backporting easier. PR-URL: nodejs#14453 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #13988 (the only conflict was in the internal errors list) + re-ordering the internal errors list alphabetically for future backports.