test: replace CRLF by LF in a fixture#14437
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:crlf2lf
Closed
test: replace CRLF by LF in a fixture#14437vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:crlf2lf
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:crlf2lf
Conversation
test/fixtures/test-error-first-line-offset.js is used in the test/sequential/test-module-loading.js, but the line break type is insignificant. It can be replaced for consistency.
Contributor
Author
cjihrig
approved these changes
Jul 23, 2017
lpinca
approved these changes
Jul 23, 2017
refack
approved these changes
Jul 23, 2017
jasnell
approved these changes
Jul 24, 2017
TimothyGu
approved these changes
Jul 24, 2017
Contributor
Author
|
Landed in 44bb140 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 25, 2017
test/fixtures/test-error-first-line-offset.js is used in the test/sequential/test-module-loading.js, but the line break type is insignificant. It can be replaced for consistency. PR-URL: #14437 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
test/fixtures/test-error-first-line-offset.js is used in the test/sequential/test-module-loading.js, but the line break type is insignificant. It can be replaced for consistency. PR-URL: #14437 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
test/fixtures/test-error-first-line-offset.jsis used in thetest/sequential/test-module-loading.js, but the line break type is insignificant. It can be replaced for consistency.