Conversation
|
Thank you! Some suggestions:
|
|
Or even better, use |
|
And maybe the "Refs:" line in the commit message need not be prefixed by "- ". |
|
I will correct it, thx. |
Change the `module.paths` type to `string[]`. According to alphabetical order, Move the `module.paths` after `module.parent`. Refs: nodejs#14371 (comment)
|
Should I append Refs every commit, or just the first time? |
|
@atever Fixing follow up commits will be squashed, so the first time suffices. |
| [exports shortcut]: #modules_exports_shortcut | ||
| [module resolution]: #modules_all_together | ||
| [native addons]: addons.html No newline at end of file | ||
| [native addons]: addons.html |
There was a problem hiding this comment.
cc @nodejs/documentation
This diff appears because we did not have a line break in this last line previously. Maybe it is worth to set some rule for this when doc linting is landed.
|
@vsemozhetbyt got it, thx. |
Remove excess empty lines
|
@atever I think the line break after the |
XadillaX
left a comment
There was a problem hiding this comment.
I think you can remove the [WIP] tag now.
|
Gained a lot, thanks for your patience. 😊 |
|
|
||
| * {string[]} | ||
|
|
||
| The search paths for the module. |
There was a problem hiding this comment.
This is a bit terse. Perhaps expand the explanation just a bit?
There was a problem hiding this comment.
I agree that a few more words should be added. Maybe also a link to the parts about module resolution.
@atever would you like to submit another PR?
PR-URL: #14435 Refs: #14371 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
PR-URL: #14435 Refs: #14371 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #14371 (comment)
Checklist
Affected core subsystem(s)