Closed
Conversation
Remove common.mustCall() in test that might connect to a server already running on the local host.
Member
Author
Member
Author
|
OK to fast-track this one as trivial and important to fix tests? |
2 tasks
addaleax
approved these changes
Jul 3, 2017
Member
addaleax
left a comment
There was a problem hiding this comment.
OK to fast-track this one as trivial and important to fix tests?
I would say so – I can’t really tell how many other people have a server on port 80 running regularly on the machine on which they run tests.
refack
approved these changes
Jul 3, 2017
Member
Author
refack
reviewed
Jul 3, 2017
| assert.doesNotThrow(() => { | ||
| http.request({hostname: v}).on('error', common.mustCall()).end(); | ||
| http.request({host: v}).on('error', common.mustCall()).end(); | ||
| http.request({hostname: v}).on('error', () => {}).end(); |
Contributor
There was a problem hiding this comment.
Maybe add a comment that we don't care about the connection just about hostname type checking?
Maybe even go as far as:
const dontCare = () => {};
http.request({hostname: v}).on('error', dontCare).end();
http.request({host: v}).on('error', dontCare).end();Just so no one revert-reverts this
hiroppy
approved these changes
Jul 4, 2017
lpinca
approved these changes
Jul 4, 2017
Member
Author
|
Landed in 5b1d12a |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 4, 2017
Remove common.mustCall() in test that might connect to a server already running on the local host. PR-URL: nodejs#14065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 4, 2017
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Remove common.mustCall() in test that might connect to a server already running on the local host. PR-URL: #14065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Remove common.mustCall() in test that might connect to a server already running on the local host. PR-URL: #14065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Remove common.mustCall() in test that might connect to a server already running on the local host. PR-URL: #14065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove common.mustCall() in test that might connect to a server already
running on the local host.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http