v4.x backport change https://github.com/nodejs/node/pull/12839#13105
Closed
gabrielcsapo wants to merge 1 commit intonodejs:v4.xfrom
gabrielcsapo:v4.x
Closed
v4.x backport change https://github.com/nodejs/node/pull/12839#13105gabrielcsapo wants to merge 1 commit intonodejs:v4.xfrom gabrielcsapo:v4.x
gabrielcsapo wants to merge 1 commit intonodejs:v4.xfrom
gabrielcsapo:v4.x
Conversation
Contributor
|
v4.x is in maintenance mode, so I don't think we are accepting feature additions anymore for that branch. /cc @nodejs/lts |
Author
|
:( okay, I will keep this open till someone closes it. I tried! :) |
Member
|
Thanks for the contribution @gabrielcsapo! Unfortunately as @mscdex says, v4.x has gone into maintenance mode so we are no longer backporting anything except critical security fixes. If you're still interested in submitting a PR you could take a look at our good first contribution issues, or check out http://nodetodo.org/ if there's nothing suitable there (guide to contributing here). Mentoring is always available! If you need any help comment on here or elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to backport #12839 to 4
make -j4 test(UNIX), orvcbuild test(Windows) passes