Closed
Conversation
Contributor
|
Might want to mention that |
Contributor
|
Why not add |
Contributor
|
@silverwind it seems it's not so simple: #5514 (comment) But sure, it would be a better solution. |
Member
Author
Done. |
seishun
approved these changes
Feb 3, 2017
Contributor
seishun
left a comment
There was a problem hiding this comment.
LGTM unless someone implements vcbuild lint.
seishun
reviewed
Feb 3, 2017
CONTRIBUTING.md
Outdated
Contributor
There was a problem hiding this comment.
I don't like how the text between brackets is longer than the text it's supposed to clarify. Maybe it's better just mention lint and jslint separately.
jasnell
requested changes
Feb 3, 2017
CONTRIBUTING.md
Outdated
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead.
lpinca
approved these changes
Feb 4, 2017
jasnell
approved these changes
Feb 4, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 6, 2017
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead. PR-URL: nodejs#11151 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in dccd97d |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 9, 2017
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead. PR-URL: nodejs#11151 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead. PR-URL: nodejs#11151 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead. PR-URL: nodejs#11151 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Would need backport PRs to land on v4 or v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
vcbuildonly supportsjslint.vcbuild lintwill notwork because there is no
linttask specified invcbuild.bat. Updatedocumentation to use
vcbuild jslintinstead.Checklist
Affected core subsystem(s)
doc