doc: remove Chris Dickinson from active releasers#11011
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom Jan 28, 2017
Merged
doc: remove Chris Dickinson from active releasers#11011bnoordhuis merged 1 commit intonodejs:masterfrom
bnoordhuis merged 1 commit intonodejs:masterfrom
Conversation
Trott
approved these changes
Jan 26, 2017
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM. Easy enough to put him back if he starts doing releases again.
cjihrig
approved these changes
Jan 26, 2017
ChALkeR
approved these changes
Jan 26, 2017
Member
ChALkeR
left a comment
There was a problem hiding this comment.
LGTM. Perhaps it's also the time to remove «and io.js» from the line above =).
jasnell
approved these changes
Jan 26, 2017
Fishrock123
approved these changes
Jan 26, 2017
thefourtheye
approved these changes
Jan 27, 2017
evanlucas
approved these changes
Jan 28, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: nodejs#11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
12d33ca to
56f4f09
Compare
Member
Author
|
Thanks, landed in 56f4f09.
I noticed that but I decided to leave it in because it's correct in that io.js releases were signed with one of the listed keys. Perhaps the tense should be "are" or "will have been" instead of "will be." |
Member
That contradicts with «active releasers» and removing Chris from that list, then. Perhaps:
|
Member
Author
The README itself doesn't mention "active releasers" anywhere. I've filed #11054 to reword and remove the "and io.js" part. |
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: #11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: #11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: #11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: #11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
The last release Chris did was v1.8.1 from April 2015. PR-URL: #11011 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last release Chris did was v1.8.1 from April 2015.