test: fix flaky test-http-client-timeout-event#10293
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix flaky test-http-client-timeout-event#10293Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition.
Member
Author
|
Sample CI failure: https://ci.nodejs.org/job/node-test-commit-freebsd/5892/nodes=freebsd10-64/console not ok 464 parallel/test-http-client-timeout-event
---
duration_ms: 1.240
severity: fail
stack: |-
assert.js:85
throw new assert.AssertionError({
^
AssertionError: 0 === 1
at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-client-timeout-event.js:28:12)
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5) |
Member
Author
|
I am able to replicate that failure locally by running the test in parallel with itself: tools/test.py -j 32 parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-event parallel/test-http-client-timeout-eventResult: === release test-http-client-timeout-event ===
Path: parallel/test-http-client-timeout-event
assert.js:85
throw new assert.AssertionError({
^
AssertionError: 0 === 1
at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-client-timeout-event.js:28:12)
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-client-timeout-event.js
=== release test-http-client-timeout-event ===
Path: parallel/test-http-client-timeout-event
assert.js:85
throw new assert.AssertionError({
^
AssertionError: 0 === 1
at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-client-timeout-event.js:28:12)
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-client-timeout-event.js
[00:01|% 100|+ 30|- 2]: Done Running the same command with the changes in this PR results in success. |
Member
Author
Member
Author
|
@nodejs/testing |
Member
Author
|
The widget keeps reporting arm as failing on various pull requests even when it's successful (like here). Not sure what's up with that, but I guess /cc @jbergstroem as an FYI. |
Member
Author
|
CI stress test showing current master failing: https://ci.nodejs.org/job/node-stress-single-test/1074/nodes=freebsd10-64/console CI stress test showing this branch passing: https://ci.nodejs.org/job/node-stress-single-test/1075/nodes=freebsd10-64/console |
santigimeno
approved these changes
Dec 16, 2016
cjihrig
approved these changes
Dec 16, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 19, 2016
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: nodejs#10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 348e69c |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: nodejs#10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: #10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: #10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: #10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Race condition caused occasional failure on CI. Chained callbacks used to remove race condition. PR-URL: #10293 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test http
Description of change
Race condition caused occasional failure on CI. Chained callbacks used
to remove race condition.