test: test-crypto-stream.js - assert.equal -> assert.strictEqual#10065
Closed
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:crypto-stream-test-patch
Closed
test: test-crypto-stream.js - assert.equal -> assert.strictEqual#10065davidmarkclements wants to merge 1 commit intonodejs:masterfrom davidmarkclements:crypto-stream-test-patch
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:crypto-stream-test-patch
Conversation
cjihrig
approved these changes
Dec 1, 2016
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
Not sure what the preferred style for the second change is, but if the linter is ok with it, LGTM.
Contributor
Member
Author
|
oh regarding that - I forgot to mention, the linter made me split across the lines - otherwise it exceeds the column count more than open to alternative suggestion for breaking up across lines (maybe put has into "expected" var?) |
Contributor
|
It passed linting, so I'm ok with it. |
changes assert.equal to assert.strictEqual to ensure specificity
Member
|
Landed in ea79a57, thanks! |
addaleax
pushed a commit
that referenced
this pull request
Dec 4, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: #10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: #10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: nodejs#10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: nodejs#10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: #10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: #10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
changes assert.equal to assert.strictEqual to ensure specificity PR-URL: #10065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, crypto
Description of change
changes
assert.equaltoassert.strictEqualto ensure specificityedit: correct subsystem