-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Support bufferSize option with recursive mode in fs.opendir #55764
Copy link
Copy link
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Metadata
Metadata
Assignees
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Related to: #48820 and #55744
After the
recursiveoption was added toreaddirandopendir, it was noted that when specifyingbufferSizealongsiderecursive: true, the result ofopendirwas incorrect. This is fixed in #55744 . However, the fix is a naive solution, and doesn't properly respect thebufferSizeoption. Furthermore, it could result in a blocked event loop. This should be fixed.I recommend reading the discussion in #48820 for more information. This should only involve changes to the
Dirclass inlib/internal/fs/dir.js.