Skip to content

Postinstall causes trouble when built for electron #1095

@maxkorp

Description

@maxkorp

On postinstall, we try to require the nodegit binary as a test. When we build the module for not-vanilla-node, the binary is there but does not load (since we run from npm from vanilla node, regardless of what we're building for). I don't really know a good way around this short of either just checking that the binary exists instead of if it's loadable, or removing it entirely.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions