Skip to content

fix: use @arethetypeswrong/cli to auto add source exports#43

Merged
fengmk2 merged 1 commit intomasterfrom
use-attw
Jun 19, 2024
Merged

fix: use @arethetypeswrong/cli to auto add source exports#43
fengmk2 merged 1 commit intomasterfrom
use-attw

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 19, 2024 •
edited by coderabbitai bot
Loading

eggjs/egg#5257 (comment)

Summary by CodeRabbit

  • New Features

    • Added support for Node.js version 22 in testing workflows.
    • Introduced a new dev dependency for type checking.

  • Chores

    • Updated scripts in package.json to enhance pre-publish checks.
    • Included new secret CODECOV_TOKEN in the testing workflow configuration.

@coderabbitai
Copy link

coderabbitai bot commented Jun 19, 2024 •
edited
Loading

Warning

Review failed

The pull request is closed.

Walkthrough

The recent changes span configuration file updates for CI workflows and package enhancements. The Node.js versions for testing have been updated to include version 22, and a new secret CODECOV_TOKEN has been added. Additionally, in the release.yml workflow, the checkTest: false configuration has been removed. The package.json file saw a revamped "preci" script and a new dev dependency, along with revised import paths for TypeScript files.

Changes

File Change Summary
.github/workflows/nodejs.yml Updated Node.js versions for testing to include 22 and added a new secret CODECOV_TOKEN.
.github/workflows/release.yml Removed checkTest: false configuration from a workflow job.
package.json Updated "preci" script, added @arethetypeswrong/cli dev dependency, and modified import paths to include "source" fields pointing to TypeScript files.

Poem

In the land of nodes, we have a delight,
A secret token to keep code tight.
From sixteen to twenty-two, our tests now expand,
With lint and new tools, our code is so grand.
Paths set right, no longer askew,
Cheers to the changes that pull us through!

🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@socket-security
Copy link

socket-security bot commented Jun 19, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@arethetypeswrong/cli@0.15.3 Transitive: environment, filesystem, network, shell, unsafe +46 39.9 MB andrewbranch

View full report↗︎

@codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.69%. Comparing base (6c98053) to head (fffe598).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files           3        3           
  Lines         333      333           
  Branches       98       98           
=======================================
  Hits          322      322           
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit 9ded1af into master Jun 19, 2024
@fengmk2 fengmk2 deleted the use-attw branch June 19, 2024 02:28
fengmk2 pushed a commit that referenced this pull request Jun 19, 2024
@semantic-release-bot
Release 2.0.3
75fbf02 
[skip ci]

## [2.0.3](v2.0.2...v2.0.3) (2024-06-19)

### Bug Fixes

* use @arethetypeswrong/cli to auto add source exports ([#43](#43)) ([9ded1af](9ded1af)), closes [/github.com/eggjs/egg/issues/5257#issuecomment-2176524639](https://github.com/node-modules//github.com/eggjs/egg/issues/5257/issues/issuecomment-2176524639)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fengmk2