Skip to content

Feature/dakonr dx sync to #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kircheneer merged 4 commits into from
Nov 29, 2022
Merged

Feature/dakonr dx sync to #188

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d95a756
return diff to improve dx
dakonr Nov 26, 2022
a29dc61
added tests for sync_to and sync_from methods
dakonr Nov 27, 2022
2585996
run black on init
dakonr Nov 28, 2022
e43ae8f
moved pylint: disable=too-many-arguments comment
dakonr Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added tests for sync_to and sync_from methods
  • Loading branch information
@dakonr
dakonr committed Nov 27, 2022
commit a29dc61add2c3b37d7660e92c491dd3655739548
7 changes: 5 additions & 2 deletions tests/unit/test_diffsync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ def test_diffsync_diff_self_with_no_data_has_no_diffs(generic_diffsync):
def test_diffsync_sync_self_with_no_data_is_noop(generic_diffsync):
generic_diffsync.sync_complete = mock.Mock()
generic_diffsync.sync_from(generic_diffsync)
generic_diffsync.sync_to(generic_diffsync)
diff = generic_diffsync.sync_to(generic_diffsync)
# Check if the returning Diff object has diffs
assert not diff.has_diffs()
# sync_complete() should only be called if something actually changed
assert not generic_diffsync.sync_complete.called

Expand Down Expand Up @@ -486,12 +488,13 @@ def test_diffsync_sync_to_w_diff(backend_a, backend_b):
backend_a.diff_from = mock.Mock()
backend_a.diff_to = mock.Mock()
# Perform full sync
backend_b.sync_to(backend_a, diff=diff)
result_diff = backend_b.sync_to(backend_a, diff=diff)
# Assert none of the diff methods have been called
assert not backend_b.diff_from.called
assert not backend_b.diff_to.called
assert not backend_a.diff_from.called
assert not backend_a.diff_to.called
assert result_diff.has_diffs()


def test_diffsync_sync_from_w_diff(backend_a, backend_b):
Expand Down