Repository navigation
Implement SQL Clause in Where IS NOT NULL - #226
Merged
Merged
Conversation
nargotik
commented
Apr 12, 2019
Contributor
- new feature
- BC break no
- doc PR: nette/docs
added 2 commits
April 12, 2019 17:08
Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL
Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL
Member
|
Please do not reopen new pull request, you can change code via force push. |
Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL
Contributor
Author
|
Sorry about it, i'm kinda noob in Git :) |
added 2 commits
April 12, 2019 17:32
Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL
Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL
Contributor
Author
Have you view this implementation ? |
Contributor
|
@nargotik test is still missing. database/tests/Database/SqlPreprocessor.phpt Line 101 in 8b6230d |
Contributor
Author
Ok added, test Failing test from coveralls mentions a file not changed at all :-) |
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.