Skip to content

Add sync_lyrics_to_tags option#625

Open
kamack38 wants to merge 2 commits intoncmpcpp:masterfrom
kamack38:feat/sync_lyrics_to_tags
Open

Add sync_lyrics_to_tags option#625
kamack38 wants to merge 2 commits intoncmpcpp:masterfrom
kamack38:feat/sync_lyrics_to_tags

Conversation

@kamack38
Copy link

@kamack38 kamack38 commented Feb 12, 2025

This closes #273, because it adds the ability to automatically sync lyrics after editing a file.
Issues:

  • Only works when the editor is a console editor
  • Only works on MP3 files (it uses the MPEG fileref)

@arybczak
Copy link
Collaborator

Thanks and sorry for the delay. Why only mp3 files? See writeXiphComments in tags.cpp, won't that work with the LYRICS field?

@kamack38
Copy link
Author

No problem, but after all this time, I'm not really sure whether this is a good PR. I'd rather that it would be implemented at the MPD protocol level. There was some discussion at MusicPlayerDaemon/MPD#350, but I didn't receive any response and had other stuff to do, so I stopped pursuing it. Maybe when I have time I'll try to do a PR there. So the question is whether do You really want to add an intermediate solution to ncmpcpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch/write lyrics from tags

2 participants

Comments