Skip to content

Add exclude_pattern option#421

Open
quite wants to merge 1 commit intoncmpcpp:masterfrom
quite:dbexclude
Open

Add exclude_pattern option#421
quite wants to merge 1 commit intoncmpcpp:masterfrom
quite:dbexclude

Conversation

@quite
Copy link
Contributor

@quite quite commented Oct 29, 2020

No description provided.

@arybczak
Copy link
Collaborator

What's the difference between this and random_exclude_pattern?

@quite
Copy link
Contributor Author

quite commented Dec 14, 2020

The result of this exclusion is that certain paths/files that comes from mpd will not show up in search and add-random. But they are still browseable. I admit the use-case might be very particular to myself... I have a symlink tree for sorting songs i various ways, but don't want duplicates when searching.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not sure that this needs to be done in this case. What does this block do...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in the last commit

@quite
Copy link
Contributor Author

quite commented Jun 21, 2021

Have rebased this now!

@quite
Copy link
Contributor Author

quite commented May 28, 2024

Rebased again

@arybczak
Copy link
Collaborator

I know it's been ages, but since you rebased recently I guess you keep using it.

  1. The "Exclude pattern for whole database" is misleading, because it's not considered in browser nor media library.
  2. This options make the random_exclude_pattern obsolete, so it'd be better to replace it with this option.

I'm not sure what to do with (1).

@quite
Copy link
Contributor Author

quite commented Jul 25, 2024

Oh, ages indeed. I've been using this patch for over a decade, the PR is modern :-)

1. The "Exclude pattern for whole database" is misleading, because it's not considered in browser nor media library.

Actually it ought to be applied for media library as well, I see that my last commit here was a mistake. Going to revert. I rarely use media library. I can change the name of the config option and adjust the comments, and possibly rename the variable. But the idea is that it should still be possible to use the Browser to find things that are excluded by this option.

2. This options make the `random_exclude_pattern` obsolete, so it'd be better to replace it with this option.

I'd say they have different use cases. random_exclude_pattern only applies to add-random, I think it's fine to keep it. But, I see that it does not seem to be applied to AddRandomTag, is that an oversight? Feels like the exclude should apply also to the random songs found by artist/albumartist/album tags.

@quite quite changed the title Add an optional pattern to exclude from all database results Add exclude_pattern option Jul 25, 2024
@quite quite force-pushed the dbexclude branch 2 times, most recently from 0dcb63f to 44e5793 Compare July 25, 2024 08:12
@quite
Copy link
Contributor Author

quite commented Jul 25, 2024

There, did some adjustments. I could also fix the random_exclude_pattern apply on AddRandomTag in a separate commit here, if that makes sense to you.

@quite
Copy link
Contributor Author

quite commented Aug 23, 2024

Rebased

@quite quite force-pushed the dbexclude branch 2 times, most recently from cf9f085 to 2097911 Compare September 17, 2024 10:48
@quite quite force-pushed the dbexclude branch 2 times, most recently from 40d046f to af7d2d3 Compare February 27, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments