Add more options to configure the progressbar#392
Add more options to configure the progressbar#392elkowar wants to merge 4 commits intoncmpcpp:masterfrom
Conversation
…acters for start, end and seperator of the bar
|
Thanks! Can you show one/a few screens of how can this be used to prettify the progressbar? |
|
Also, is this change backward compatible? I.e. if someone has it set to 2-3 chars, will his progressbar change after this PR is merged? |
|
the change should be perfectly backwards compatible, as i made sure that the behaviour on 2 and 3 characters is the same as before. exampleslight rounding of the outer edges of the bar simple ascii characters |
|
any updates on this @arybczak ? |
|
@arybczak I would love to see this merged. Any updates? |
src/statusbar.cpp
Outdated
| if (Config.progressbar[2] != '\0') | ||
|
|
||
| // set the different bar characters depending on the amount of configured chars | ||
| char bar_start_char = Config.progressbar[0]; |
There was a problem hiding this comment.
These need to be wchar_t because progressbar is std::wstring.
doc/ncmpcpp.1
Outdated
| .TP | ||
| .B progressbar_look = TEXT | ||
| This variable defines the look of progressbar. Note that it has to be exactly two or three characters long. | ||
| This variable defines the look of progressbar. Note that it has to be between two and five characters long. |
There was a problem hiding this comment.
Please add a description of all possible states, i.e. what happens when this is set to 2/3/4/5 characters.
|
Ping. |
|
ohhh, sorry, I had completely forgotten about this at this point ^^' I'll fix the issues later today! |
|
@elkowar any way I can pitch in? Would love to see this merged. I can help with the documentation bit. |
If you wanna take this over, feel free to. I've stopped using ncmpcpp a while ago, and haven't really had the motivation to finish this, I'm afraid ^^' |
|
I'd be glad to. How does one take over a PR though? Should I make a fresh one implementing the same changes? |
|
@arybczak Is it looking okay now? |
This PR adds the option to configure up to 5 different characters for the progressbar.
This allows users to for example use powerline-fonts to theme their progress bar.
The characters provided are: