Take album artists into account when adding random albums#354
Open
rtoijala wants to merge 1 commit intoncmpcpp:masterfrom
Open
Take album artists into account when adding random albums#354rtoijala wants to merge 1 commit intoncmpcpp:masterfrom
rtoijala wants to merge 1 commit intoncmpcpp:masterfrom
Conversation
Collaborator
|
It looks like this isn't going to work if the album artist tag is missing 🤔 |
When adding a random album, the album artist intuitively should be the same for all added songs. Currently, this is not so, so when adding e.g. 'Greatest Hits' you can get many different albums. Fix this by randomly selecting one album artist whose songs to add. See comment inside the code for (insignificant) limitations. Fixes Github issue ncmpcpp#159.
3b3999c to
f7e3f78
Compare
Author
|
I rebased on top of 0.9.2 since that is the version I could easily compile and run using the Arch Linux PKGBUILD. I updated the logic around missing album artist tags. It now works in a way I consider sensible:
I have tested this with databases with all album artists present, with no album artists present, and with some album artists present and some missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a random album, the album artist intuitively should
be the same for all added songs. Currently, this is not so,
so when adding e.g. 'Greatest Hits' you can get many different albums.
Fix this by randomly selecting one album artist whose songs to add.
See comment inside the code for (insignificant) limitations.
Fixes Github issue #159.
This replaces pull request #198, since I some time ago deleted the repo that was based on.