Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Fix Bug 1420371: Samsung, Firefox, footnote, icon update#4605

Merged
schalkneethling merged 1 commit into
masterfrom
1420371-icons
Dec 22, 2017
Merged

Fix Bug 1420371: Samsung, Firefox, footnote, icon update#4605
schalkneethling merged 1 commit into
masterfrom
1420371-icons

Conversation

@stephaniehobson

@stephaniehobson stephaniehobson commented Dec 21, 2017

Copy link
Copy Markdown
Contributor
  • Add Samsung Internet Browser Icon
  • Update Firefox icon
  • Change footnote icon from [ ] to *

@stephaniehobson

Copy link
Copy Markdown
Contributor Author

@Elchi3 🎁

@schalkneethling

Copy link
Copy Markdown

Not sure if I missed a step but, I fetched this branch, updated the sub-modules, started docker, ran build-static, restarted web as well as kumascript, and have gulp running.

With all of the above, the new/changed icons are not showing up:

screen shot 2017-12-21 at 12 16 14

and

screen shot 2017-12-21 at 12 19 07

@jwhitlock

Copy link
Copy Markdown
Contributor

If you are removing compat-icons.eot, etc., you'll need to remove the reference from kuma/static/styles/base/fonts/compat-icons.scss as well.

@schalkneethling

Copy link
Copy Markdown

If you are removing compat-icons.eot, etc., you'll need to remove the reference ...

Ah yes, that is why there was the message about unliked files from Gulp

@stephaniehobson

Copy link
Copy Markdown
Contributor Author

Oh no, I put the new files in /static/ instead of /kuma/static/. I hope I still have them...

/static/ is my nemesis.

@stephaniehobson

Copy link
Copy Markdown
Contributor Author

I should add, the macro doesn't add Samsung Internet Browser to the table yet, so you'll have to test by changing the class on one of the others with dev tools.

@stephaniehobson

Copy link
Copy Markdown
Contributor Author

Okay, try it again :)

@schalkneethling schalkneethling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🐇

@schalkneethling schalkneethling merged commit 9e9b27f into master Dec 22, 2017
@jwhitlock jwhitlock deleted the 1420371-icons branch January 16, 2018 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants