Handle 204 No Content status in response processing #1304
Closed
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
felixweinberger
requested changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Thanks for the PR! However, I don't think we should accept 204 here. The MCP spec explicitly requires 202 Accepted for notifications - accepting 204 would mask bugs in non-compliant servers.
See: https://modelcontextprotocol.io/specification/draft/basic/transports#sending-messages-to-the-server
The fix should be in the server returning 204 (looks like the Inspector based on the stack trace).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1303
Motivation and Context
We should handle all possible and valid HTTP status code.
How Has This Been Tested?
Tested with my local MCP server which returns 204.
Breaking Changes
No
Types of changes
Checklist
Additional context