Skip to content

[BUILD] Bump node in .nvmrc to 20.17.0 due to unsupported engine warnings#576

Closed
hesreallyhim wants to merge 8 commits intomodelcontextprotocol:mainfrom
hesreallyhim-forks:hesreallyhim/build-update-nvmrc-to-20-17
Closed

[BUILD] Bump node in .nvmrc to 20.17.0 due to unsupported engine warnings#576
hesreallyhim wants to merge 8 commits intomodelcontextprotocol:mainfrom
hesreallyhim-forks:hesreallyhim/build-update-nvmrc-to-20-17

Conversation

@hesreallyhim
Copy link
Copy Markdown
Contributor

@hesreallyhim hesreallyhim commented May 26, 2025 •
edited
Loading

Motivation and Context

I was starting to work on a PR for this repo, so I followed the instructions, ran nvm i which installed node v.20.16.0, per .nvmrc, then ran npm i, and found there were dependency resolution conflicts warnings about incorrect version of node:

hesreallyhim@Doctors-MacBook-Pro-4 modelcontextprotocol % npm -v
10.8.1
hesreallyhim@Doctors-MacBook-Pro-4 modelcontextprotocol % node -v
v20.16.0
hesreallyhim@Doctors-MacBook-Pro-4 modelcontextprotocol % npm i
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-core@1.19.5',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-formats@1.8.2',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-functions@1.9.4',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-parsers@1.0.5',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-ref-resolver@1.0.5',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@stoplight/spectral-runtime@1.1.4',
npm warn EBADENGINE   required: { node: '^16.20 || ^18.18 || >= 20.17' },
npm warn EBADENGINE   current: { node: 'v20.16.0', npm: '10.8.1' }
npm warn EBADENGINE }

added 782 packages, and audited 783 packages in 5s

317 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

AFTER CHANGE TO .nvmrc:

hesreallyhim@Doctors-MacBook-Pro-4 modelcontextprotocol % nvm i
Found '/Users/hesreallyhim/coding/projects/modelcontextprotocol/modelcontextprotocol/.nvmrc' with version <v20.17.0>
v20.17.0 is already installed.
Now using node v20.17.0 (npm v10.8.2)
hesreallyhim@Doctors-MacBook-Pro-4 modelcontextprotocol % npm i

added 782 packages, and audited 783 packages in 4s

317 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

i think this was probably introduced in #283 , stoplight is a dep of asyncapi which is a dep of mintlify. Not sure why it wasn't caught during the CI/CD, probably because it's just a warning, but maybe consider adding a check for this in github actions or something.

How Has This Been Tested?

Ran validate, generate, serve commands as per CONTRIBUTING.md, no issues reported.

Breaking Changes

Probably not(?). The site has already been deployed with node 20.16.0 without breaking (despite warning), site looks fine now, it's not a library that people would have as a dep anyway i think...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@hesreallyhim hesreallyhim changed the title [BUILD] Bump node in .nvmrc to 20.17.0 due to deps resolution conflict [BUILD] Bump node in .nvmrc to 20.17.0 due to unsupported engine warnings May 26, 2025
@dsp-ant
Copy link
Copy Markdown
Member

dsp-ant commented Nov 21, 2025

I am okay iwth that change but it would require an update on the package-lock. I am closing this PR but pushing the change directly as a commit

@dsp-ant dsp-ant closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsp-ant dsp-ant dsp-ant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hesreallyhim @dsp-ant