[VIRTS-4674] Resolve Empty PDF Generation Issues#67
Merged
mkultraWasHere merged 2 commits intoSep 8, 2023
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
mkultraWasHere
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
When running an operation that generates long facts, users were encountering an error when attempting to export the operation to a PDF. The issue was due to an extremely long fact value that caused the table row to span multiple pages, which caused in error in the
reportlab.platypuslibrary.As row heights need to be dynamically generated, I reduced the
TABLE_CHAR_LIMIT(the maximum length of a fact value) to something that would restrict the row to one page at the most.Type of change
How Has This Been Tested?
Prior to this update, the bug could be reproduced by the following steps:
1). Start agent and operation. When creating the operation. use the 'Discovery' adversary.
2). When the operation finished, go to Debrief, select the operation you just ran, and click
Download PDF Report.3). Ensure that the facts table is selected, and click download. The resulting PDF would be 0 bytes due to the error.
Now, the fact table will load correctly, and the PDF can be downloaded successfully.
Checklist: