Conversation
…/microsoftgraph/msgraph-sdk-javascript into JS-Migrate-To-ESLint-Part-1_#308
…icrosoftgraph/msgraph-sdk-javascript into nikitha/graph-clientside-error
Bumps [ws](https://github.com/websockets/ws) from 7.1.2 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.1.2...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikitha Chettiar <nikithauc@gmail.com>
* Fixing links * Update v3-upgrade-guide.md
* Adding the ChunkRecord interface * Adding more tests for stream resume * comments, assert conditions change * SliceRecord and comments
* 3.0.0 preview 2 package update * restore file
fix docs markdown link
* adding links to samples * removing duplicate links * adding description for typings and removing en-us
* removing node and browser; adding largefile samples * adding links of samples in docs * token credential readme change
* creating msal browser auth provider * unit test, msal browser options * error handling unit test, doc updates * rename auth provider * doc and folder name update * throw error, msal cdn reference
* 3.0.0-preview-3 release * msal updates
baywet
left a comment
There was a problem hiding this comment.
@nikithauc I'm curious to why you closed and re-opened a PR for the same thing?
This practice has multiple negative impacts:
- We had 12 comments that we still unresovled in the previous PR that we now need to track manually.
- It also looses the "viewed" status on files, pushing additional burden on reviewers to view again files they have already reviewed. Which is especially painful on large pull requests. (see screenshot below)
I'm not going to review 180 files entirely a second time.
Thanks for taking in some of the initial comments, especially around the dependencies and auth topics.
|
The merge was messy because of which I decided to recreate this release branch. I wanted to avoid the risk of wrong conflict resolution and keep this release branch close to the latest preview release. The new commits introduced in this PR after #480 are: The unresolved comment in #480 have been mapped to issues and will be tracked as enhancement issues. |
|
@nikithauc Thanks for the additional context. Can I suggest the following alternatives whenever you want to "tidy-up" a pull request:
Again, re-opening pull requests adds burden not only for the reviewers, but also for anybody who's following the repo (additional notifications which force people to triage things another time). |
Closed #480 and create a new PR containing the support for MSAL Browser.
This release contains:
Issues in MileStone 3.0.0
V3 Upgrade Guide