This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Update generated code#22
Merged
Merged
Conversation
baywet
suggested changes
Jan 31, 2022
Member
|
the amount of changes makes it really hard to actually review the PR (the page keeps freezing the browser). |
Contributor
Author
|
Made changes to remove the need for dependency injection. Also, I've used the |
baywet
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run code gen to incorporate output formatter selection changes.
The OpenAPI source file revision used in the generation is microsoftgraph/msgraph-metadata@8388bce
Issues
To work around microsoft/kiota#1052, the OpenApi file had to be modified. The changes made are outlined below:
\/([\w]+)\/\1e.g./me/onenote/sections/{onenoteSection-id}/parentSectionGroup/parentSectionGroup\/([\w]+)\/\{\1-id\}replacing the match with/$1/{$1Item-id}e.g./deviceManagement/termsAndConditions/{termsAndConditions-id}->/deviceManagement/termsAndConditions/{termsAndConditionsItem-id}