Remove code lenses for "set as interpreter"#19853
Merged
karrtikr merged 2 commits intomicrosoft:mainfrom Sep 16, 2022
Merged
Conversation
…s their references and instances. Also removed the setShebangInterpreter
|
|
| registerVisibilityFilter(filter: IInterpreterStatusbarVisibilityFilter): void; | ||
| } | ||
|
|
||
| export const IShebangCodeLensProvider = Symbol('IShebangCodeLensProvider'); |
Member
There was a problem hiding this comment.
You may have to remove the CodeLensProvider and TextDocument imports on line 2.
Author
There was a problem hiding this comment.
@karthiknadig Hi Karthik! Just removed those and pushed the changes. Everything is passing now.
karthiknadig
approved these changes
Sep 16, 2022
karrtikr
approved these changes
Sep 16, 2022
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for removing the references as well.
|
Renamed the PR appropriately as that is what goes into our release notes. Also edited PR description to reference the issue this PR was about. |
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
Closes microsoft#3854 Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as their references and instances. Also removed the setShebangInterpreter.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…19853) Closes microsoft/vscode-python#3854 Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as their references and instances. Also removed the setShebangInterpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3854
Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as their references and instances. Also removed the setShebangInterpreter.