Conversation
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR adjusts how classpath-change events from the Java Language Server map to Test Explorer refreshes, avoiding unnecessary full refreshes (and UI flicker) when the event comes from non-test projects (e.g., buildSrc in Gradle multi-module workspaces).
Changes:
- Improves project matching by selecting the most specific (longest) matching project root for a classpath URI.
- Adds handling for “ancestor URI” updates (e.g., workspace root) by refreshing all affected child test projects.
- Skips refreshing entirely when the classpath URI doesn’t correspond to any known test project, preventing a full explorer reload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
chagong
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unnecessary full refresh of test explorer when classpath changes in non-test projects
When a Gradle multi-module project contains a buildSrc directory, the Java Language Server fires onDidClasspathUpdate events for all Java projects — including buildSrc, which has no test sources. Previously, refreshProject() used startsWith to match the incoming classpath URI against existing test controller items. When no match was found (as with buildSrc), it fell back to loadJavaProjects(), triggering a full refresh of the entire test explorer tree view. This caused the UI to flicker and reset unnecessarily.