Conversation
Performance enhancements for Get-UnitySetupInstance
Wrap each path individually in quotes to fix exports
Add the option to specify a Hash parameter when calling Find-UnitySetupInstaller, which looks for URIs using the hash provided, rather than detecting it based on the public builds available on the download archive page.
Added private build support
Bump minor version
Support Linux_IL2CPP component
Fix for detecting unity 2021 version and windows il2cpp
Add unity accelerator parameters
cishawe
approved these changes
Jun 15, 2022
| [UnitySetupComponent]::StandardAssets = , [io.path]::Combine("$Path", "Editor\Standard Assets"); | ||
| [UnitySetupComponent]::Windows_IL2CPP = , [io.path]::Combine("$playbackEnginePath", "windowsstandalonesupport\Variations\win32_development_il2cpp"); | ||
| [UnitySetupComponent]::Windows_IL2CPP = , [io.path]::Combine("$playbackEnginePath", "windowsstandalonesupport\Variations\win32_development_il2cpp"), | ||
| [io.path]::Combine("$playbackEnginePath", "windowsstandalonesupport\Variations\win32_player_development_il2cpp");; |
| $sharedArgs += "-cacheServerEndpoint", $CacheServerEndpoint | ||
| $sharedArgs += "-adb2" | ||
| $sharedArgs += "-enableCacheServer" | ||
| if ( $CacheServerNamespacePrefix) { $sharedArgs += "-cacheServerNamespacePrefix", $CacheServerNamespacePrefix} |
Contributor
There was a problem hiding this comment.
nit: missing space before } (since there is a space after the {
Contributor
There was a problem hiding this comment.
nit: Missing space after $CacheServerNamespacePrefix
| @@ -1822,6 +1871,14 @@ function Start-UnityEditor { | |||
| if ( $RunTests ) { $sharedArgs += '-runTests' } | |||
| if ( $ForceFree) { $sharedArgs += '-force-free' } | |||
Contributor
There was a problem hiding this comment.
nit: Missing space after $ForceFree
| if (Test-Path -PathType Leaf -Path $file) { | ||
| $fileMatchInfo = Select-String -Path $file -Pattern "UNITY_VERSION.+`"(\d+\.\d+\.\d+[fpba]\d+).*`"" | ||
| if($null -ne $fileMatchInfo) | ||
| { |
Contributor
There was a problem hiding this comment.
nit: All other {'s are in line with the if statement in this block.
| [parameter(Mandatory = $false)] | ||
| [UnitySetupComponent] $Components = [UnitySetupComponent]::All | ||
| [UnitySetupComponent] $Components = [UnitySetupComponent]::All, | ||
|
|
Contributor
There was a problem hiding this comment.
nit: space between param's is inconsistent with the rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.