Added lumin component installers#148
Merged
jwittner merged 9 commits intomicrosoft:developfrom Apr 29, 2019
StephenHodgson:dev-lumin-component-installer
Merged
Added lumin component installers#148jwittner merged 9 commits intomicrosoft:developfrom StephenHodgson:dev-lumin-component-installer
jwittner merged 9 commits intomicrosoft:developfrom
StephenHodgson:dev-lumin-component-installer
Conversation
Member
|
Lets wait on this until UnitySetup can download versions that include the component. |
Contributor
Author
|
Agreed, just got started on the work for early feedback. |
Contributor
Author
|
@jwittner 2019 beta is out with accessible download components |
Contributor
Author
|
This PR is ready for review |
Member
|
Note: this will conflict with #161 . |
Member
|
I'll pull this down and test it out tomorrow. =) |
Member
|
Bah, UnitySetup throws an error if I search for 2019.1.0b9. New Issue here: #165 |
# Conflicts: # UnitySetup/UnitySetup.psm1
Contributor
Author
|
This should be ready to test once the 2019 bugs are fixed. |
# Conflicts: # UnitySetup/UnitySetup.psm1
jwittner
requested changes
Apr 26, 2019
Member
jwittner
left a comment
There was a problem hiding this comment.
Was able to find the installers for this new component, but I have concerns over the BuildTarget change.
Contributor
Author
|
@jwittner, I was able to validate that the command like works! |
jwittner
approved these changes
Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this may not be availible until 2019 gets into beta or until we can download/install alpha builds, but I went ahead and did the preliminary work.
Fixes #147