fix(tracing): add missing error handlers to createWriteStream pipes - #41227
Merged
dcrousso merged 1 commit intoJun 10, 2026
Merged
Conversation
Without an 'error' handler on createWriteStream, a write failure
(disk full, permissions) causes the wrapping promise to never resolve
and the unhandled 'error' event to crash the process.
Add .on('error', reject) to match the existing correct pattern
in testTracing.ts:396 and blob.ts:88.
Contributor
Test results for "MCP"7279 passed, 1119 skipped Merge workflow run. |
dcrousso
approved these changes
Jun 10, 2026
Contributor
Test results for "tests 1"3 flaky39488 passed, 771 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.on('error', reject)to twocreateWriteStreampipe chains that only had'close'handlerstestTracing.ts:396,blob.ts:88)