Create Wrapper Script for Installing Typings - #1143
Conversation
**Bug** **Fix** Create a node script that wraps `typings-core`. This script will continue installation of all packages, even if some packages do not have typings files. Closes microsoft#1140
| @@ -0,0 +1 @@ | |||
|
No newline at end of file |
|||
There was a problem hiding this comment.
Seems that npm requires some sort of index/main file, so I just created this empty one.
There was a problem hiding this comment.
As discussed, let's move the core logic into index.js
|
Did a basic test pass with Node 0.12. My main concern was whether local module installs would behave, but it seems to work just fine. |
| @@ -1,5 +1,4 @@ | |||
| # Build Folders (you can keep bin if you'd like, to store dlls and pdbs) | |||
| [Bb]in/ | |||
There was a problem hiding this comment.
These were ignoring the bin directory in the new local npm module. I thought it was better to remove them rather than override include the bin directory. No other new files seem to have been added from this
There was a problem hiding this comment.
I would prefer not to include bin by default, as this will likely be an issue if certain projects are built that aren't hooked up into our default project targets
There was a problem hiding this comment.
I'll just exclude top level /bin dirs then? Or revert the gitignore change and force add the node bin files?
| "author": "Microsoft", | ||
| "version": "1.0.0", | ||
| "description": "Internal tool that aquires typings to power Node.js Tools For Visual Studio IntelliSense", | ||
| "license": "Apache 2", |
There was a problem hiding this comment.
Apache 2.0
|
👍 |
Issue #1140
Bug
If a single package in the current project does not have a typings file, we fail to install any typings. This results in a poor IntelliSense experience.
Fix
Create a node script that wraps
typings-core. This script will continue installation of all packages, even if some packages do not have typings files.Testing
Tested on Node 6 so far with a few different scenarios, including projects where the typings for an installed package do not exist. Still have to test on earlier versions of node.
Closes #1140