Repository navigation
Upgrade mammoth to 1.13 - #2647
Open
Patrick Creighton (patrick-5546) wants to merge 1 commit into
Open
Patrick Creighton (patrick-5546) wants to merge 1 commit into
Patrick Creighton (patrick-5546) wants to merge 1 commit into
Conversation
mammoth 1.12.2 handles complex field separators and ends without a
matching start, which raised IndexError ("pop from empty list") and
failed the whole DOCX conversion. It also avoids excessive backtracking
when parsing unterminated strings in crafted documents. 1.12.0 and 1.13.0
add hyperlinked images, unquoted HYPERLINK hrefs, w:customXml content,
and moved paragraphs tracked as revisions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Patrick Creighton (@patrick-5546) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2646.
Like #1452, this bumps
mammoth~=1.11.0tomammoth~=1.13.0in thedocxandallextras. From mammoth's NEWS:wp:anchorandwp:inlineelements, and hyperlink fields with unquoted hrefs.numStyleLinkrefers to themselves. It also fixes a Windows-only--output-dirissue in mammoth's own CLI.IndexError, and unterminated strings in crafted documents no longer cause excessive backtracking.w:customXmlcontent, handles moved paragraphs and runs tracked as revisions, and improves escaping in mammoth's Markdown writer, which MarkItDown doesn't use.This adds a regression test for unmatched field marks. It fails with mammoth 1.11.0 and passes with 1.13.0.
Checks:
packages/markitdown: 1098 passed, 11 skipped.markitdown-ocr: 108 passed.markitdown-mcp: 21 passed.