.NET: Re-enable the "retrieve object" check in StateManager#1881
Merged
.NET: Re-enable the "retrieve object" check in StateManager#1881
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables a previously disabled validation check that prevents reading state as object type. The check was previously commented out pending upstream updates, but is now being enforced.
Key Changes:
- Uncommented the
NotSupportedExceptionthat was disabled in StateManager.cs
78e858b to
9cb1dc3
Compare
9cb1dc3 to
db47402
Compare
crickman
approved these changes
Nov 14, 2025
7e18673 to
2bcc069
Compare
markwallace-microsoft
approved these changes
Dec 10, 2025
Merged
This was referenced Apr 3, 2026
Merged
This was referenced Apr 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As we implemented more of Checkpointing and proper support for polymorphic values behind
PortableValue, there was a brief period where the Declarative layer needed to gradually switch from the old way of using the APIs toPortableValue. To make this integration easier, we temporarily disabled the check that users are not trying to readobjectfrom the state store.Description
This change restores the check.
Closes #1369
Contribution Checklist
Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.