Don't erase signature type parameters in signaturesRelatedTo by ahejlsberg · Pull Request #48092 · microsoft/TypeScript

ahejlsberg · 2022-03-02T21:26:46Z

ahejlsberg · 2022-03-02T21:27:15Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

typescript-bot · 2022-03-02T21:27:19Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at b46f196. You can monitor the build here.

typescript-bot · 2022-03-02T21:27:19Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at b46f196. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-03-02T21:27:19Z

Heya @ahejlsberg, I've started to run the diff-based community code test suite on this PR at b46f196. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-03-02T21:27:19Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at b46f196. You can monitor the build here.

typescript-bot · 2022-03-02T21:42:27Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48092

_Metric	_main	₄₈₀₉₂	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{333,096k (± 0.00%)}	_{333,111k (± 0.01%)}	_{+16k (+ 0.00%)}	_333,070k	_333,146k
_{Parse Time}	_{2.03s (± 0.54%)}	_{2.01s (± 0.39%)}	_{-0.02s (- 0.94%)}	_1.99s	_2.03s
_{Bind Time}	_{0.89s (± 1.06%)}	_{0.88s (± 0.53%)}	_{-0.01s (- 1.12%)}	_0.87s	_0.89s
_{Check Time}	_{5.53s (± 0.54%)}	_{5.51s (± 0.53%)}	_{-0.03s (- 0.49%)}	_5.45s	_5.58s
_{Emit Time}	_{6.33s (± 0.50%)}	_{6.31s (± 0.75%)}	_{-0.02s (- 0.30%)}	_6.22s	_6.42s
_{Total Time}	_{14.78s (± 0.30%)}	_{14.70s (± 0.41%)}	_{-0.08s (- 0.55%)}	_14.60s	_14.87s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,556k (± 0.50%)}	_{194,018k (± 0.61%)}	_{+1,462k (+ 0.76%)}	_192,379k	_195,661k
_{Parse Time}	_{0.85s (± 0.70%)}	_{0.85s (± 0.58%)}	_{0.00s ( 0.00%)}	_0.85s	_0.87s
_{Bind Time}	_{0.57s (± 0.87%)}	_{0.57s (± 1.34%)}	_{0.00s ( 0.00%)}	_0.56s	_0.59s
_{Check Time}	_{7.41s (± 0.56%)}	_{7.39s (± 0.41%)}	_{-0.02s (- 0.30%)}	_7.30s	_7.45s
_{Emit Time}	_{2.47s (± 0.47%)}	_{2.47s (± 1.04%)}	_{-0.00s (- 0.04%)}	_2.41s	_2.55s
_{Total Time}	_{11.30s (± 0.48%)}	_{11.28s (± 0.22%)}	_{-0.02s (- 0.21%)}	_11.25s	_11.35s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,157k (± 0.00%)}	_{325,141k (± 0.00%)}	_{-16k (- 0.00%)}	_325,122k	_325,194k
_{Parse Time}	_{1.57s (± 0.79%)}	_{1.56s (± 0.53%)}	_{-0.01s (- 0.57%)}	_1.54s	_1.58s
_{Bind Time}	_{0.78s (± 1.23%)}	_{0.77s (± 0.68%)}	_{-0.01s (- 0.77%)}	_0.76s	_0.78s
_{Check Time}	_{5.42s (± 0.64%)}	_{5.38s (± 0.47%)}	_{-0.04s (- 0.72%)}	_5.33s	_5.43s
_{Emit Time}	_{3.33s (± 0.98%)}	_{3.30s (± 0.66%)}	_{-0.03s (- 0.81%)}	_3.27s	_3.35s
_{Total Time}	_{11.10s (± 0.56%)}	_{11.02s (± 0.44%)}	_{-0.08s (- 0.72%)}	_10.92s	_11.11s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,688k (± 0.01%)}	_{288,693k (± 0.01%)}	_{+5k (+ 0.00%)}	_288,654k	_288,726k
_{Parse Time}	_{1.34s (± 1.47%)}	_{1.32s (± 1.10%)}	_{-0.02s (- 1.27%)}	_1.30s	_1.37s
_{Bind Time}	_{0.73s (± 0.93%)}	_{0.73s (± 0.85%)}	_{-0.01s (- 0.68%)}	_0.72s	_0.74s
_{Check Time}	_{5.09s (± 0.72%)}	_{5.07s (± 0.64%)}	_{-0.02s (- 0.35%)}	_5.00s	_5.16s
_{Emit Time}	_{3.54s (± 1.78%)}	_{3.46s (± 2.05%)}	_{-0.08s (- 2.15%)}	_3.35s	_3.61s
_{Total Time}	_{10.69s (± 0.79%)}	_{10.58s (± 0.97%)}	_{-0.12s (- 1.08%)}	_10.38s	_10.86s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{446,283k (± 0.07%)}	_{446,461k (± 0.06%)}	_{+178k (+ 0.04%)}	_445,449k	_446,615k
_{Parse Time}	_{1.86s (± 0.40%)}	_{1.85s (± 0.42%)}	_{-0.01s (- 0.64%)}	_1.83s	_1.86s
_{Bind Time}	_{0.70s (± 0.83%)}	_{0.69s (± 0.71%)}	_{-0.01s (- 1.28%)}	_0.68s	_0.70s
_{Check Time}	_{12.95s (± 0.88%)}	_{12.85s (± 0.53%)}	_{-0.10s (- 0.74%)}	_12.70s	_13.01s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.51s (± 0.77%)}	_{15.40s (± 0.45%)}	_{-0.12s (- 0.75%)}	_15.26s	_15.55s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,366k (± 0.00%)}	_{535,721k (± 0.00%)}	_{+356k (+ 0.07%)}	_535,654k	_535,776k
_{Parse Time}	_{2.59s (± 0.73%)}	_{2.58s (± 0.33%)}	_{-0.01s (- 0.42%)}	_2.57s	_2.61s
_{Bind Time}	_{1.16s (± 0.96%)}	_{1.16s (± 0.76%)}	_{-0.01s (- 0.69%)}	_1.15s	_1.18s
_{Check Time}	_{1.50s (± 0.68%)}	_{1.49s (± 0.27%)}	_{-0.01s (- 0.53%)}	_1.48s	_1.50s
_{Emit Time}	_{0.07s (± 4.66%)}	_{0.07s (± 3.14%)}	_{-0.00s (- 2.74%)}	_0.07s	_0.08s
_{Total Time}	_{5.33s (± 0.35%)}	_{5.31s (± 0.20%)}	_{-0.03s (- 0.49%)}	_5.28s	_5.33s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{5 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₈₀₉₂	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-03-02T21:45:24Z

@ahejlsberg
Great news! no new errors were found between main..refs/pull/48092/merge

ahejlsberg · 2022-03-15T13:47:28Z

@typescript-bot run dt

typescript-bot · 2022-03-15T13:47:32Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at b46f196. You can monitor the build here.

ahejlsberg · 2022-03-15T16:15:15Z

Hmm, an this appears to cause an OOM in babel__traverse on Definitely Typed. Plus a number of other somewhat inscrutable errors that probably are correct, but probably also of little value. Not sure we want to take this fix.

ahejlsberg · 2022-03-15T16:15:53Z

@RyanCavanaugh Curious if you have an opinion here.

RyanCavanaugh · 2022-03-15T16:28:45Z

The linked bug is a regression and also very surprising. It'd be nice if we could get this worked out

andrewbranch · 2022-05-03T22:02:16Z

@typescript-bot pack this

typescript-bot · 2022-05-03T22:02:19Z

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at b46f196. You can monitor the build here.

andrewbranch · 2023-09-11T16:11:40Z

@typescript-bot pack this

typescript-bot · 2023-09-11T16:11:43Z

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 5d1e364. You can monitor the build here.

typescript-bot · 2023-09-11T16:13:57Z

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157626/artifacts?artifactName=tgz&fileId=8AE456DFBF777DAB343BE58ED5DA2B1D703C94E6262068ACFBBC5DD091EB14FC02&fileName=/typescript-5.0.0-insiders.20230911.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-48092-16".;

# Conflicts: # src/compiler/checker.ts

ahejlsberg added 3 commits March 2, 2022 13:25

Unify signatures in signaturesRelatedTo

b615109

Accept new baselines

63b1229

Add regression test

b46f196

typescript-bot assigned ahejlsberg Mar 2, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 2, 2022

Merge branch 'main' into fix48070

5d1e364

ahejlsberg mentioned this pull request Aug 28, 2022

Overloaded function with at least one generic overload can be assigned to any function with at least the same number of parameters #50050

Open

RyanCavanaugh mentioned this pull request Mar 1, 2023

Design Meeting Notes, 2023-03-01 #53057

Closed

RyanCavanaugh mentioned this pull request Mar 30, 2023

Assignment of incompatible types missed by the compiler in combination with generic interface with function template parameter #53568

Closed

andrewbranch mentioned this pull request Sep 11, 2023

Method infers the wrong type when passing a value that is typealiased that uses union and intersection types #55648

Closed

ahejlsberg added 2 commits October 18, 2023 06:26

Merge branch 'main' into fix48070

f33f092

# Conflicts: # src/compiler/checker.ts

Manually re-implement changes in checker.ts

bdfd342

Accept baseline changes

a1047da

Conversation

ahejlsberg commented Mar 2, 2022

Uh oh!

ahejlsberg commented Mar 2, 2022

Uh oh!

typescript-bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 2, 2022

Uh oh!

typescript-bot commented Mar 2, 2022

Uh oh!

ahejlsberg commented Mar 15, 2022

Uh oh!

typescript-bot commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Mar 15, 2022

Uh oh!

ahejlsberg commented Mar 15, 2022

Uh oh!

RyanCavanaugh commented Mar 15, 2022

Uh oh!

andrewbranch commented May 3, 2022

Uh oh!

typescript-bot commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbranch commented Sep 11, 2023

Uh oh!

typescript-bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

typescript-bot commented Mar 2, 2022 •

edited

Loading

typescript-bot commented Mar 2, 2022 •

edited

Loading

typescript-bot commented Mar 2, 2022 •

edited

Loading

typescript-bot commented Mar 2, 2022 •

edited

Loading

typescript-bot commented Mar 15, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading

typescript-bot commented Sep 11, 2023 •

edited

Loading