Slightly less conservative check in isConstraintPosition#46526
Merged
ahejlsberg merged 2 commits intomainfrom Oct 26, 2021
Merged
Slightly less conservative check in isConstraintPosition#46526ahejlsberg merged 2 commits intomainfrom
ahejlsberg merged 2 commits intomainfrom
Conversation
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the inline community code test suite on this PR at 042debb. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 042debb. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 042debb. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 042debb. You can monitor the build here. Update: The results are in! |
Collaborator
|
@ahejlsberg Here they are:Comparison Report - main..46526
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@ahejlsberg |
Member
Author
|
Tests look good and performance not affected. I think this one is good to go. |
| function update<T extends Control, K extends keyof T>(control : T | undefined, key: K, value: T[K]): void { | ||
| if (control !== undefined) { | ||
| control[key] = value; | ||
| } |
Member
There was a problem hiding this comment.
Can a subsequent else if discriminate between Button and Checkbox, or are we now stuck with T?
Member
Author
There was a problem hiding this comment.
In a subsequent else if the type of control would be undefined. But if you mean a subsequent if inside the block, then yes:
if (control !== undefined) { // Type of control is T | undefined
control[key] = value; // Type of control is T
if (control.type === "button") { // Type of control is Control
control.text; // Type of control is Button
}
}
andrewbranch
approved these changes
Oct 26, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…6526) * Slight adjustment to check in isConstraintPosition * Add regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46495.