🤖 User test baselines have changed for refs/heads/master#37498
🤖 User test baselines have changed for refs/heads/master#37498sandersn merged 1 commit intomicrosoft:masterfrom
Conversation
08c7b55 to
8b3b48c
Compare
4309c03 to
b50e437
Compare
b50e437 to
7f3dced
Compare
7f3dced to
fc14de5
Compare
sandersn
left a comment
There was a problem hiding this comment.
Everything looks correct to me.
| [XX:XX:XX] Error: /vscode/src/vs/editor/browser/controller/pointerHandler.ts(46,45): Property 'msContentZooming' does not exist on type 'CSSStyleDeclaration'. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/workbench.web.api.ts(249,25): Type 'readonly ICommand[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator. | ||
| [XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/splitview/splitview.ts(113,3): Type '"none" | null' is not assignable to type 'string'. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/services/search/common/search.ts(617,20): This condition will always return true since the function is always defined. Did you mean to call it instead? |
|
|
||
| > xterm@X.X.X build /xtermjs | ||
| > tsc -b ./tsconfig.all.json | ||
| node_modules/@types/ws/index.d.ts(44,39): error TS2694: Namespace '"url"' has no exported member 'URL'. |
There was a problem hiding this comment.
specific to master -- did @types/ws just update?
| Type 'T' is not assignable to type 'SecurityModel'. | ||
| node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(375,25): error TS2694: Namespace 'Protocol' has no exported member 'Security'. | ||
| node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(376,25): error TS2694: Namespace 'Protocol' has no exported member 'Network'. | ||
| node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(377,23): error TS1099: Type argument list cannot be empty. |
| node_modules/discord.js/typings/index.d.ts(1742,103): error TS2694: Namespace 'NodeJS' has no exported member 'Timeout'. | ||
| node_modules/discord.js/typings/index.d.ts(1744,34): error TS2694: Namespace 'NodeJS' has no exported member 'Timeout'. | ||
| node_modules/discord.js/typings/index.d.ts(1747,34): error TS2694: Namespace 'NodeJS' has no exported member 'Timeout'. | ||
| node_modules/discord.js/typings/index.d.ts(2980,21): error TS2694: Namespace 'NodeJS' has no exported member 'Timeout'. |
There was a problem hiding this comment.
probably due to discord updating
| node_modules/follow-redirects/index.js(371,13): error TS2339: Property 'cause' does not exist on type 'CustomError'. | ||
| node_modules/follow-redirects/index.js(372,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'. | ||
| node_modules/follow-redirects/index.js(379,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'. | ||
| node_modules/follow-redirects/index.js(491,25): error TS2339: Property 'code' does not exist on type 'Error'. |
There was a problem hiding this comment.
probably updates to follow-redirects?
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(207,27): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(212,24): error TS2322: Type 'null' is not assignable to type '(path: any, callback: any) => void'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(217,28): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(221,14): error TS2774: This condition will always return true since the function is always defined. Did you mean to call it instead? |
There was a problem hiding this comment.
these are correct as far as TS' current understanding of JS. We don't expect people to overwrite methods in the constructor:
class C {
constructor(fs) {
this.readFile = fs.readFile ? fs.readFile : null
if (this.readFile) {
this._readJson = (path, callback) => this.readFile(...)
}
}
readFile(path, callback) {
}
}This is from "CachedInputFileSystem.js", which tells you all need to know I think.
| [XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1075,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1087,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1093,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(146,7): This condition will always return true since the function is always defined. Did you mean to call it instead? |
There was a problem hiding this comment.
not clear whether to trust the types or the values in this case, but they definitely don't agree.
| [XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1093,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(146,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(160,7): This condition will always return true since the function is always defined. Did you mean to call it instead? | ||
| [XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(83,7): This condition will always return true since the function is always defined. Did you mean to call it instead? |
There was a problem hiding this comment.
upon reading more examples, they look like they're just leftovers from pre-strictNullChecks that the compiler didn't notice before.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript