Conversation
tcare
approved these changes
Feb 27, 2020
Contributor
|
Apologies for the rename merge :D |
dtzar
suggested changes
Feb 27, 2020
Contributor
dtzar
left a comment
There was a problem hiding this comment.
LGTM other than the one comment. I assume you've run this and checked to make sure all the proper tags show up across the various levels.
Contributor
Author
Tested it pretty extensively in my own subscription, but I'll queue up a CI build here too just to verify. |
Contributor
Author
dtzar
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the need to add the BuildId parameter and tagging logic to the train/evaluate scripts. The tags are instead specified when the experiment is submitted. The register script pulls the BuildId from the tag.
Part of #140.