Allow splitting namespace (and other) (sub)packages across file systems #18561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18561 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22300 22304 +4
=======================================
+ Hits 21939 21943 +4
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
67fd750 to
01a2992
Compare
Scan all elements of "sys.path" for (sub)modules. Submodules are no longer loaded relative to the parent module's `__path__`. This allows selectively overriding a frozen submodule from the file system. Signed-off-by: Matthias Urlichs <matthias@urlichs.de>
Signed-off-by: Matthias Urlichs <matthias@urlichs.de>
01a2992 to
a79cfe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The restriction of not allowing a split between file systems might save some import time, but the cost is that you can't selectively update a buggy file in ROM or .frozen with a fixed version without uploading the whole package.
Testing
Test
tests/cpydiff/core_import_split_ns_pkgs.pyhas been modified accordingly.Trade-offs and Alternatives
IMHO the additional load time incurred by scanning all of
sys.pathis negligible.On the plus side, this patch (a) shaves a few bytes off the MPy binary, at least on Unix (I didn't yet check any others) and (b) allows for faster debug-fix cycles, esp. when RAM is too tight to load all of a large package ensemble that works perfectly well when it's in
.frozen.