esp8266: Remove OTA variant from ESP8266_GENERIC board. #18540
Merged
+3
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7133c55 to
6704100
Compare
The OTA variant of the ESP8266_GENERIC board was never fully completed in its functionality. It relies on the https://github.com/pfalcon/yaota8266 component which was also never fully finished and has been unmaintained for many years. This commit removes this variant and it's associated build support. It makes it an "old_variant" so the existing historical firmware is still listed on the download page. Signed-off-by: Damien George <damien@micropython.org>
6704100 to
5305285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The OTA variant of the ESP8266_GENERIC board was never fully completed in its functionality and has not been tested in a long time (by me at least).
It relies on the https://github.com/pfalcon/yaota8266 component which was also never fully finished and has been unmaintained for many years.
This PR removes this variant and it's associated build support. It makes it an "old_variant" as per #18539 so the existing historical firmware is still listed on the download page.
Testing
I haven't done any testing, but there's not much that can be done.
Trade-offs and Alternatives
We could keep this around, but the esp8266 is now a Tier 3 port, so makes sense to streamline it a little to ease maintenance.