Skip to content

Remove DisabledDiagnostics from the tests - #1370

Merged
meziantou merged 13 commits into
mainfrom
feature/disabled-diagnostics-cleanup-1d88c7
Sep 1, 2026
Merged

Remove DisabledDiagnostics from the tests#1370
meziantou merged 13 commits into
mainfrom
feature/disabled-diagnostics-cleanup-1d88c7

Conversation

@meziantou

@meziantou meziantou commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Removes every DisabledDiagnostics usage from the tests (75 calls across 26 files, now 0). Most of them were leftovers from the migration to the Roslyn SDK harness: the original tests filtered the diagnostics to a single rule, so each rule of a multi-rule analyzer got its own test class that disabled all the others.

There is one commit per analyzer.

What changed

Merged the per-rule test classes (24 classes → 10). Each merged class now runs every rule its analyzer reports, so a snippet that triggers two rules has to say so:

Analyzer Was Now
OptimizeLinqUsageAnalyzer 9 classes OptimizeLinqUsageAnalyzerTests
EqualityShouldBeCorrectlyImplementedAnalyzer MA0077 / MA0094 / MA0095 / MA0097 EqualityShouldBeCorrectlyImplementedAnalyzerTests
DoNotUseBlockingCallInAsyncContextAnalyzer _AsyncContext / _NonAsyncContext DoNotUseBlockingCallInAsyncContextAnalyzerTests
MakeMethodStaticAnalyzer _Methods / _Properties MakeMethodStaticAnalyzerTests
AvoidClosureWhenUsingConcurrentDictionaryAnalyzer MA0105 / MA0106 ConcurrentDictionaryMustPreventClosureWhenAccessingTheKeyAnalyzerTests
OptionalParametersAttributeAnalyzer MA0087 / MA0088 OptionalParametersAttributeAnalyzerTests
UseStringComparisonAnalyzer MA0001 / MA0074 UseStringComparisonAnalyzerTests
DoNotUseDefaultEqualsOnValueTypeAnalyzer MA0065 / MA0066 DoNotUseDefaultEqualsOnValueTypeAnalyzerTests
DoNotImplicitlyConvertDateTimeToDateTimeOffsetAnalyzer MA0132 / MA0133 DoNotCompareDateTimeWithDateTimeOffsetAnalyzerTests
ArgumentExceptionShouldSpecifyArgumentNameAnalyzer MA0043 in its own class ArgumentExceptionShouldSpecifyArgumentNameAnalyzerTests

Colliding method names got a disambiguating prefix or suffix. Six tests that were byte-identical duplicates across a merged pair were dropped (one in the DateTimeOffset pair, five in the UseStringComparison pair) — no coverage is lost, the surviving copy asserts exactly the same thing.

Flagged the diagnostics the fix reveals, using the pattern already in the repo (FixedState.MarkupHandling = MarkupMode.Allow + CodeFixTestBehaviors.FixOne), so the test asserts a single fix application and the new diagnostic is visible in the expected code:

  • fixing MA0088 reveals MA0087
  • fixing MA0077 adds IEquatable<T>, which makes MA0095 report on the result (8 tests)
  • MA0156 and MA0157 contradict each other, so fixing one reveals the other

Flagged the other rules in the test code where a snippet reported more than the rule under test: UseLangwordInXmlComment (MA0154 / MA0218 / MA0219), UseStringComparison (the char overload tests now flag MA0001 and assert its fix), one DoNotUseBlockingCallInAsyncContext snippet (MA0045), and three AvoidClosureWhenUsingConcurrentDictionary snippets (MA0106).

Removed the disabling that was pure noise: ProcessStartAnalyzer disabled the two rules each test did not cover, and ArgumentExceptionShouldSpecifyArgumentName disabled MA0043, even though no snippet reported them.

Note for the reviewer

Three OptimizeLinqUsage order tests reported MA0159 only because their samples used an identity selector (OrderBy(x => x)). Flagging MA0159 there was not an option: with FixOne, the harness applied the MA0159 fix instead of the one under test, rewriting the sample to Order() and destroying what the test verified. Those samples now use a real selector (x => -x, x => x.Length) so the tests stay focused on MA0030 and MA0063.

Validation

  • dotnet build on the solution: 0 warnings, 0 errors
  • All Roslyn versions pass: roslyn4.8 (3742), roslyn4.14 (3769), roslyn5.0 (3797), roslyn5.6 (3821), roslyn5.9 (3854)
  • Every commit was checked out in turn and the test project compiles at each one
  • dotnet run --project src/DocumentationGenerator produced no markdown changes

meziantou added 13 commits August 31, 2026 22:15
@meziantou
Merge the ArgumentExceptionShouldSpecifyArgumentName test classes and…
544fa5c 
… stop disabling MA0043

The MA0043 tests lived in their own class and the other class disabled MA0043,
even though no test snippet reported it. Both rules of the analyzer are now
verified by a single class.
@meziantou
Merge the AvoidClosureWhenUsingConcurrentDictionary test classes
9a39f34 
MA0105 and MA0106 had one test class each, disabling the other rule. The
snippets that report both rules now flag MA0106 explicitly.
@meziantou
Merge the DoNotImplicitlyConvertDateTimeToDateTimeOffset test classes
4d4a801 
The MA0133 class disabled MA0132 and held a single test that the MA0132 class
already covered verbatim.
@meziantou
Merge the DoNotUseBlockingCallInAsyncContext test classes
d095038 
The async and non-async context classes disabled each other's rule. Only one
snippet actually reported the other rule, and it now flags MA0045.
@meziantou
Merge the DoNotUseDefaultEqualsOnValueType test classes
7d3444e 
MA0065 and MA0066 had one test class each, disabling the other rule, even
though no snippet reported both.
@meziantou
Merge the EqualityShouldBeCorrectlyImplemented test classes
5ccf0d2 
The MA0077 class disabled MA0095 because fixing MA0077 adds IEquatable<T>,
which makes MA0095 report on the result. Those tests now assert a single fix
application and flag MA0095 in the fixed code.
@meziantou
Merge the MakeMethodStatic test classes
38a87f4 
MA0038 and MA0041 had one test class each, disabling the other rule.
@meziantou
Flag the contradicting rule instead of disabling it in the async suff…
69faef7 
…ix tests

MA0156 and MA0157 contradict each other, so the fix of one reveals the other.
The two code fix tests now assert a single fix application and flag the
contradicting rule in the fixed code.
@meziantou
Merge the OptimizeLinqUsage test classes
2298219 
Nine classes covered one rule each and disabled all the others. The order
related tests used identity selectors, which made MA0159 report on them; they
now use a real selector so each test stays focused on the rule it covers.
@meziantou
Merge the OptionalParametersAttribute test classes
ab0ad0a 
MA0087 and MA0088 had one test class each, disabling the other rule. Fixing
MA0088 reveals MA0087, so that test now asserts a single fix application and
flags MA0087 in the fixed code.
@meziantou
Stop disabling the other ProcessStart rules in the tests
6ca6183 
Every test disabled the two rules it did not cover, even though no snippet
reported more than one of MA0161, MA0162 and MA0163.
@meziantou
Flag the other UseLangwordInXmlComment rules instead of disabling them
1558570 
The snippets that report MA0154, MA0218 or MA0219 in addition to the rule
under test now flag them.
@meziantou
Merge the UseStringComparison test classes
b010bb9 
MA0001 and MA0074 had one test class each, disabling the other rule, with five
tests duplicated between them. The char overload tests now flag MA0001 and
assert its fix.
@meziantou
meziantou enabled auto-merge September 1, 2026 03:57
@meziantou
meziantou merged commit ff29aa5 into main Sep 1, 2026
13 checks passed
@meziantou
meziantou deleted the feature/disabled-diagnostics-cleanup-1d88c7 branch September 1, 2026 03:59
This was referenced Sep 3, 2026
Closed
Merged
Merged
Closed
Closed
Merged
Open
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 14, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
vdolek pushed a commit to EvilBrainsTechnology/EvilCase that referenced this pull request Sep 14, 2026
@dependabot
Bump Meziantou.Analyzer from 3.0.200 to 3.0.257 (#493)
211a03c 
Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer)
from 3.0.200 to 3.0.257.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._

## 3.0.257

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.257>

## What's Changed
* Use GetTypeByMetadataName unless the type is commonly declared as
internal in several assemblies by @​meziantou in
meziantou/Meziantou.Analyzer#1523


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.256...3.0.257

## 3.0.256

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.256>

## What's Changed
* Fix metadata names that could never resolve in MA0003, MA0001 and
MA0060 by @​meziantou in
meziantou/Meziantou.Analyzer#1522


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.255...3.0.256

## 3.0.255

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.255>

## What's Changed
* Add an option to include extension methods from namespaces that are
not imported in the rules using OverloadFinder by @​meziantou in
meziantou/Meziantou.Analyzer#1521


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.254...3.0.255

## 3.0.254

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.254>

## What's Changed
* Remove the unreachable string.Join branch of MA0089 by @​meziantou in
meziantou/Meziantou.Analyzer#1504
* Fix MA0018 reporting one diagnostic per event accessor by @​meziantou
in meziantou/Meziantou.Analyzer#1505
* chore(deps): update all dependencies to 1.0.172 by @​renovate[bot] in
meziantou/Meziantou.Analyzer#1507
* Report MA0070 on every declaration that can be obsolete by @​meziantou
in meziantou/Meziantou.Analyzer#1508
* Remove the discarded message argument of MA0080 by @​meziantou in
meziantou/Meziantou.Analyzer#1509
* Report MA0068 on the parameter and property placements of
NotNullIfNotNull by @​meziantou in
meziantou/Meziantou.Analyzer#1510
* Include the preprocessor trivia in the MA0202 branch comparison by
@​meziantou in meziantou/Meziantou.Analyzer#1511
* Report MA0179 when the constant is on the left of the length
comparison by @​meziantou in
meziantou/Meziantou.Analyzer#1512
* Fix the MA0166 message saying "available tokens" by @​meziantou in
meziantou/Meziantou.Analyzer#1513
* Detect the ConfigureAwait of the async enumerable in the MA0004
foreach analysis by @​meziantou in
meziantou/Meziantou.Analyzer#1506
* Report MA0206 on record struct and interface declarations by
@​meziantou in meziantou/Meziantou.Analyzer#1514
* Report MA0147 on async void method groups by @​meziantou in
meziantou/Meziantou.Analyzer#1515
* Report MA0051 on expression bodies of properties, indexers, and
operators by @​meziantou in
meziantou/Meziantou.Analyzer#1517
* Clarify the MA0095 comment about the Equals(object) lookup by
@​meziantou in meziantou/Meziantou.Analyzer#1518
* Report relational and generic math NaN comparisons in MA0082 by
@​meziantou in meziantou/Meziantou.Analyzer#1519
* Cache the MA0042 "no async equivalent" results per call-site scope by
@​meziantou in meziantou/Meziantou.Analyzer#1520
* Report the contextual keywords in MA0154 by @​meziantou in
meziantou/Meziantou.Analyzer#1516


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.253...3.0.254

## 3.0.253

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.253>

## What's Changed
* Share the argument list logic of the code fixes that add an argument
by @​meziantou in
meziantou/Meziantou.Analyzer#1503


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.252...3.0.253

## 3.0.252

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.252>

## What's Changed
* Preserve the variable scope in the MA0004 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1502


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.251...3.0.252

## 3.0.251

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.251>

## What's Changed
* Keep the initialization order in the MA0004 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1496
* Do not offer the MA0082 code fix when both operands are NaN by
@​meziantou in meziantou/Meziantou.Analyzer#1497
* Report MA0224/MA0225 when an earlier assignment configures another
instance by @​meziantou in
meziantou/Meziantou.Analyzer#1498
* Fix MA0040 inserting the CancellationToken in an invalid argument
position by @​meziantou in
meziantou/Meziantou.Analyzer#1499
* Preserve argument binding in the MA0074 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1500
* Fix MA0011 inserting the IFormatProvider in an invalid argument
position by @​meziantou in
meziantou/Meziantou.Analyzer#1501


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.250...3.0.251

## 3.0.250

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.250>

## What's Changed
* Report MA0163 when an assignment cannot fix the configuration used by
Process.Start by @​meziantou in
meziantou/Meziantou.Analyzer#1489
* Fix MA0166 inserting the TimeProvider in an invalid argument position
by @​meziantou in
meziantou/Meziantou.Analyzer#1490
* Do not report MA0214 when the function cannot be made async by
@​meziantou in meziantou/Meziantou.Analyzer#1491
* Preserve argument binding in the MA0108 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1492
* Add the type to the parameter added by the MA0106 code fix on a typed
lambda by @​meziantou in
meziantou/Meziantou.Analyzer#1495


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.249...3.0.250

## 3.0.249

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.249>

## What's Changed
* MA0177: preserve nested XML elements such as <see/> when collapsing by
@​meziantou in meziantou/Meziantou.Analyzer#1481
* Fix MA0184 code fix keeping doubled braces as literal text by
@​meziantou in meziantou/Meziantou.Analyzer#1465
* Do not report MA0209/MA0210 for arguments that cannot be passed by
reference by @​meziantou in
meziantou/Meziantou.Analyzer#1469
* Do not report MA0148/MA0149 when the constant does not convert to the
operand type by @​meziantou in
meziantou/Meziantou.Analyzer#1470
* Do not report MA0028 for string.Join overloads without an AppendJoin
equivalent by @​meziantou in
meziantou/Meziantou.Analyzer#1475
* chore(deps): update all dependencies by @​renovate[bot] in
meziantou/Meziantou.Analyzer#1477
* Fix MA0193 code fix producing invalid calls with named arguments by
@​meziantou in meziantou/Meziantou.Analyzer#1486
* Do not report MA0173 when the value cannot be captured by a lambda by
@​meziantou in meziantou/Meziantou.Analyzer#1487
* Do not report MA0106 when the factory writes the captured variable by
@​meziantou in meziantou/Meziantou.Analyzer#1488


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.248...3.0.249

## 3.0.248

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.248>

## What's Changed
* Do not report MA0065 when the invoked equality member is overridden by
@​meziantou in meziantou/Meziantou.Analyzer#1485
* Do not report MA0152 when the inner await suppresses the exceptions by
@​meziantou in meziantou/Meziantou.Analyzer#1484


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.247...3.0.248

## 3.0.247

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.247>

## What's Changed
* Do not report MA0215 when ConfigureAwait changes what the method does
by @​meziantou in
meziantou/Meziantou.Analyzer#1483


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.246...3.0.247

## 3.0.246

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.246>

## What's Changed
* Fix MA0158 code fix when the field is assigned in another document by
@​meziantou in meziantou/Meziantou.Analyzer#1478
* Do not report MA0173 when the return value of CompareExchange is used
by @​meziantou in
meziantou/Meziantou.Analyzer#1479
* Do not report MA0066 on ImmutableSortedDictionary by @​meziantou in
meziantou/Meziantou.Analyzer#1480


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.245...3.0.246

## 3.0.245

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.245>

## What's Changed
* Do not report MA0158 when the value cannot be migrated to
System.Threading.Lock by @​meziantou in
meziantou/Meziantou.Analyzer#1476


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.244...3.0.245

## 3.0.244

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.244>

## What's Changed
* Fix MA0028 changing escaped braces when replacing AppendFormat with
Append by @​meziantou in
meziantou/Meziantou.Analyzer#1474


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.243...3.0.244

## 3.0.243

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.243>

## What's Changed
* Do not report MA0078 when the selector does more than casting its
element by @​meziantou in
meziantou/Meziantou.Analyzer#1473


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.242...3.0.243

## 3.0.242

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.242>

## What's Changed
* Do not report MA0111 in expression trees by @​meziantou in
meziantou/Meziantou.Analyzer#1471
* Do not offer the MA0098 Last() code fix when the source cannot be
evaluated twice by @​meziantou in
meziantou/Meziantou.Analyzer#1472


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.241...3.0.242

## 3.0.241

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.241>

## What's Changed
* Do not merge MA0148/MA0149 comparisons when the operand can change
between evaluations by @​meziantou in
meziantou/Meziantou.Analyzer#1466
* Fix MA0210 checking the wrong parameter for reordered named arguments
by @​meziantou in
meziantou/Meziantou.Analyzer#1467
* Do not report MA0184 when the interpolated string is converted to
IFormattable by @​meziantou in
meziantou/Meziantou.Analyzer#1468


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.240...3.0.241

## 3.0.240

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.240>

## What's Changed
* Remove every dollar of raw strings in MA0184 code fix by @​meziantou
in meziantou/Meziantou.Analyzer#1464


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.239...3.0.240

## 3.0.239

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.239>

## What's Changed
* Do not report MA0005 for arrays of pointers by @​meziantou in
meziantou/Meziantou.Analyzer#1460
* Fix MA0171 code fix omitting parentheses around the generated pattern
by @​meziantou in
meziantou/Meziantou.Analyzer#1461
* Do not offer the MA0044 code fix when removing ToString would drop
argument side effects by @​meziantou in
meziantou/Meziantou.Analyzer#1462
* Import System.Threading.Tasks in MA0152 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1463


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.238...3.0.239

## 3.0.238

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.238>

## What's Changed
* Preserve interpolation alignment in MA0052 code fix by @​meziantou in
meziantou/Meziantou.Analyzer#1454
* Do not report MA0160 when ContainsKey is explicitly implemented by
@​meziantou in meziantou/Meziantou.Analyzer#1453


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.237...3.0.238

## 3.0.237

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.237>

## What's Changed
* Fix MA0127 code fix producing uncompilable code for object and span
operands by @​meziantou in
meziantou/Meziantou.Analyzer#1459
* MA0113: Only report DateTime constructors with the Utc kind by
@​meziantou in meziantou/Meziantou.Analyzer#1458
* Preserve attribute inheritance behavior in the MA0179 code fix by
@​meziantou in meziantou/Meziantou.Analyzer#1457
* MA0239: Do not report GetType() on a property by @​meziantou in
meziantou/Meziantou.Analyzer#1456
* MA0052: Suggest the first declared member when the enum value has
aliases by @​meziantou in
meziantou/Meziantou.Analyzer#1455
* Fix MA0089 treating an integer start index or count as
StringComparison.Ordinal by @​meziantou in
meziantou/Meziantou.Analyzer#1452
* chore(deps): update all dependencies by @​renovate[bot] in
meziantou/Meziantou.Analyzer#1445


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.236...3.0.237

## 3.0.236

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.236>

## What's Changed
* Exclude CsWinRT-required partial types from MA0204 by @​meziantou with
@​Copilot in meziantou/Meziantou.Analyzer#1451


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.235...3.0.236

## 3.0.235

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.235>

## What's Changed
* Add MA0239: Use 'typeof' instead of 'GetType()' when the type is
sealed by @​meziantou in
meziantou/Meziantou.Analyzer#1449


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.234...3.0.235

## 3.0.234

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.234>

## What's Changed
* Add MA0228-MA0238: EventSource implementation rules by @​meziantou in
meziantou/Meziantou.Analyzer#1448


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.233...3.0.234

## 3.0.233

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.233>

## What's Changed
* Add MA0227: Avoid using 'Enumerable.Contains' on a set by @​meziantou
in meziantou/Meziantou.Analyzer#1447


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.232...3.0.233

## 3.0.232

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.232>

## What's Changed
* Add MA0226: EventSource class should be sealed by @​meziantou in
meziantou/Meziantou.Analyzer#1446


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.231...3.0.232

## 3.0.231

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.231>

## What's Changed
* Report MA0072 and MA0086 on throw expressions by @​meziantou in
meziantou/Meziantou.Analyzer#1444


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.230...3.0.231

## 3.0.230

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.230>

## What's Changed
* chore(deps): update all dependencies to 1.0.166 by @​renovate[bot] in
meziantou/Meziantou.Analyzer#1427
* Do not report MA0072 and MA0086 on the nested lambdas and local
functions by @​meziantou in
meziantou/Meziantou.Analyzer#1438
* Evaluate every component of the TimeSpan factory methods and
constructors by @​meziantou in
meziantou/Meziantou.Analyzer#1440
* Bound the regex cache, so it does not retain every configuration value
by @​meziantou in
meziantou/Meziantou.Analyzer#1441
* Do not report MA0192 when the HasFlag rewrite reorders an effectful
operand by @​meziantou in
meziantou/Meziantou.Analyzer#1442
* Bound the pooled queues by the number of items they contained by
@​meziantou in meziantou/Meziantou.Analyzer#1443


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.229...3.0.230

## 3.0.229

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.229>

## What's Changed
* Match the MA0110 regex arguments by parameter instead of position by
@​meziantou in meziantou/Meziantou.Analyzer#1439


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.228...3.0.229

## 3.0.228

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.228>

## What's Changed
* Detect the ProcessStartInfo properties set outside of the initializer
by @​meziantou in
meziantou/Meziantou.Analyzer#1437


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.227...3.0.228

## 3.0.227

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.227>

## What's Changed
* Cover the untested analyzer and fixer paths and remove the dead ones
by @​meziantou in
meziantou/Meziantou.Analyzer#1436


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.226...3.0.227

## 3.0.226

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.226>

## What's Changed
* Do not report MA0046 on events of type EventHandler<TSender,
TEventArgs> by @​meziantou in
meziantou/Meziantou.Analyzer#1435


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.225...3.0.226

## 3.0.225

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.225>

## What's Changed
* Add MA0224 and MA0225 to require the Respect* options on
JsonSerializerOptions by @​meziantou in
meziantou/Meziantou.Analyzer#1433


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.224...3.0.225

## 3.0.224

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.224>

## What's Changed
* Add MA0222 and MA0223 to require the System.Text.Json Respect* options
to be configured by @​meziantou in
meziantou/Meziantou.Analyzer#1432


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.223...3.0.224

## 3.0.223

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.223>

## What's Changed
* Remove the GetAllMembers extension methods superseded by
Meziantou.Framework.Roslyn by @​meziantou in
meziantou/Meziantou.Analyzer#1428


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.222...3.0.223

## 3.0.222

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.222>

## What's Changed
* Do not report MA0004, MA0068, MA0070, MA0160 and MA0176 in generated
code by @​meziantou in
meziantou/Meziantou.Analyzer#1430


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.221...3.0.222

## 3.0.221

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.221>

## What's Changed
* Do not report MA0028 on StringBuilder.Insert with a Substring argument
by @​meziantou in
meziantou/Meziantou.Analyzer#1429


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.220...3.0.221

## 3.0.220

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.220>

## What's Changed
* Reduce the allocations of OverloadFinder by @​meziantou in
meziantou/Meziantou.Analyzer#1426


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.219...3.0.220

## 3.0.219

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.219>

## What's Changed
* Make the analysis of generated code opt-in by @​meziantou in
meziantou/Meziantou.Analyzer#1425


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.218...3.0.219

## 3.0.218

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.218>

## What's Changed
* Gate the analysis of generated code behind
MEZIANTOU_ANALYZER_GENERATED_CODE by @​meziantou in
meziantou/Meziantou.Analyzer#1423


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.217...3.0.218

## 3.0.217

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.217>

## What's Changed
* Close the gaps in the documentation generator's configuration key
extractor by @​meziantou in
meziantou/Meziantou.Analyzer#1421


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.216...3.0.217

## 3.0.216

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.216>

## What's Changed
* Add tests for the .editorconfig options that were never set by a test
by @​meziantou in
meziantou/Meziantou.Analyzer#1419
* Report MA0130 on System.Type instances by @​meziantou in
meziantou/Meziantou.Analyzer#1422


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.215...3.0.216

## 3.0.215

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.215>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.13 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1420


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.214...3.0.215

## 3.0.214

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.214>

## What's Changed
* Resolve the NuGet packages of the tests from the global packages
folder by @​meziantou in
meziantou/Meziantou.Analyzer#1415
* Return the pooled StringBuilder on every path by @​meziantou in
meziantou/Meziantou.Analyzer#1416
* Split the TryGetValue part of MA0186 into a new rule MA0221 by
@​meziantou in meziantou/Meziantou.Analyzer#1417
* Report MA0153 when the type of a logged property or field is
classified by @​meziantou in
meziantou/Meziantou.Analyzer#1418


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.213...3.0.214

## 3.0.213

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.213>

## What's Changed
* Create the configured regexes from the options by @​meziantou in
meziantou/Meziantou.Analyzer#1414


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.212...3.0.213

## 3.0.212

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.212>

## What's Changed
* chore(deps): update all dependencies by @​renovate[bot] in
meziantou/Meziantou.Analyzer#1317


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.211...3.0.212

## 3.0.211

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.211>

## What's Changed
* Fix MA0065/MA0066 never checking for a GetHashCode override by
@​meziantou in meziantou/Meziantou.Analyzer#1391
* Report MA0124/MA0125/MA0126 on [LoggerMessage(Message = "...")] by
@​meziantou in meziantou/Meziantou.Analyzer#1392
* Report MA0179 on the array-returning GetCustomAttributes overloads by
@​meziantou in meziantou/Meziantou.Analyzer#1393
* Give MA0107 its own exclude_tostring_methods configuration key by
@​meziantou in meziantou/Meziantou.Analyzer#1394
* Report MA0060 on ignored return values behind a conditional access by
@​meziantou in meziantou/Meziantou.Analyzer#1395
* Cache the culture sensitivity of the types by @​meziantou in
meziantou/Meziantou.Analyzer#1396
* Discover the regex-valued options validated by MA0220 by @​meziantou
in meziantou/Meziantou.Analyzer#1397
* Apply the syntactic filter of MA0003 before binding the arguments by
@​meziantou in meziantou/Meziantou.Analyzer#1398
* Load the MA0104 BCL type tables lazily by @​meziantou in
meziantou/Meziantou.Analyzer#1399
* Remove the dnceng dotnet-tools NuGet source by @​meziantou in
meziantou/Meziantou.Analyzer#1400
* Share the diagnostic property keys between the analyzers and the
fixers by @​meziantou in
meziantou/Meziantou.Analyzer#1401
* Avoid the control flow analysis of MA0004 when the context is
irrelevant by @​meziantou in
meziantou/Meziantou.Analyzer#1402
* Remove dead VSIX release scripts by @​meziantou in
meziantou/Meziantou.Analyzer#1404
* Rename tests that assert no diagnostic but are named *_ShouldReport*
by @​meziantou in
meziantou/Meziantou.Analyzer#1405
* Remove the two NuGet audit suppressions by @​meziantou in
meziantou/Meziantou.Analyzer#1406
* Match the annotation attributes by name in MA0060, MA0124 and MA0139
by @​meziantou in
meziantou/Meziantou.Analyzer#1407
* Fix MA0183 false positive and missed diagnostic when named arguments
are reordered by @​meziantou in
meziantou/Meziantou.Analyzer#1408
* Do not report MA0106 on a lambda already reported by MA0105 by
@​meziantou in meziantou/Meziantou.Analyzer#1410
* Add tests for MA0080 by @​meziantou in
meziantou/Meziantou.Analyzer#1411
* Avoid walking the whole operation tree in IsInExpressionContext by
@​meziantou in meziantou/Meziantou.Analyzer#1409
* Fix two broken documentation links by @​meziantou in
meziantou/Meziantou.Analyzer#1413
* Remove the dead Roslyn 4.4 workaround from MA0099 by @​meziantou in
meziantou/Meziantou.Analyzer#1412
* Clear the pooled queue of UseLangwordInXmlCommentAnalyzer on return by
@​meziantou in meziantou/Meziantou.Analyzer#1403


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.210...3.0.211

## 3.0.210

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.210>

## What's Changed
* Fix MA0113 NullReferenceException and named-argument false negatives
by @​meziantou in
meziantou/Meziantou.Analyzer#1382
* Fix MA0078 false positive when the cast targets a captured parameter
by @​meziantou in
meziantou/Meziantou.Analyzer#1383
* Do not report MA0063 on the indexed Where overload by @​meziantou in
meziantou/Meziantou.Analyzer#1384
* Parenthesize the expressions produced by the MA0112 and MA0128 fixers
by @​meziantou in
meziantou/Meziantou.Analyzer#1385
* Do not report MA0179 on user-defined GetCustomAttribute(s) methods by
@​meziantou in meziantou/Meziantou.Analyzer#1386
* Fix MA0151 false positive on System.Object members of interface-typed
members by @​meziantou in
meziantou/Meziantou.Analyzer#1387


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.209...3.0.210

## 3.0.209

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.209>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.12 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1390
* Create the GitHub release from the commit that was built by
@​meziantou in meziantou/Meziantou.Analyzer#1389


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.208...3.0.209

## 3.0.208

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.208>

## What's Changed
* Do not offer the MA0028 Substring fix when it would duplicate side
effects by @​meziantou in
meziantou/Meziantou.Analyzer#1381


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.207...3.0.208

## 3.0.207

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.207>

## What's Changed
* Remove Feedz publishing from CI by @​meziantou in
meziantou/Meziantou.Analyzer#1380


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.206...3.0.207

## 3.0.206

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.206>

## What's Changed
* Add MA0048 options to skip parts of the file name by @​meziantou in
meziantou/Meziantou.Analyzer#1379
* Configure the reporting in generated code per rule by @​meziantou in
meziantou/Meziantou.Analyzer#1376


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.205...3.0.206

## 3.0.205

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.205>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.11 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1378


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.204...3.0.205

## 3.0.204

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.204>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.10 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1377


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.203...3.0.204

## 3.0.203

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.203>

## What's Changed
* Use Parenthesize from Meziantou.Framework.Roslyn 1.0.8 by @​meziantou
in meziantou/Meziantou.Analyzer#1374


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.202...3.0.203

## 3.0.202

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.202>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.7 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1373
* chore(deps): update dependency meziantou.framework.roslyn to 1.0.8 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1375


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.201...3.0.202

## 3.0.201

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.201>

## What's Changed
* Remove DisabledDiagnostics from the tests by @​meziantou in
meziantou/Meziantou.Analyzer#1370
* Do not report MA0214 on functions returning only completed tasks by
@​meziantou in meziantou/Meziantou.Analyzer#1372


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.200...3.0.201

Commits viewable in [compare
view](meziantou/Meziantou.Analyzer@3.0.200...3.0.257).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Sep 14, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@meziantou