Use file resources for BinaryReader#6
Merged
Conversation
Owner
|
Really nice, thanks for contributing! |
mdurrant
added a commit
that referenced
this pull request
Aug 22, 2014
Use file resources for BinaryReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've modified this package to operate on resources instead of strings. This ends up having considerable memory benefits, especially when working with larger files, as you don't need to read the entire file into memory. I've got a basic benchmark here: https://gist.github.com/jwpage/939f87fe2cf2220e7a54
__construct()will create an in-memory resource if you pass in a string.getInputString()will read out the contents of your resource, regardless of whether the BinaryReader was created with a resource or a string.testdir because I've changed it to use@dataProviders(defined inAbstractTestCase) so you can see that both file resource and string BinaryReaders pass the tests.Thanks for this package, it makes working with binary files much easier!