This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 1406546: ensure image can be pulled prior to deployment#4587
Merged
jwhitlock merged 1 commit intoDec 6, 2017
Conversation
This was referenced Dec 5, 2017
jwhitlock
approved these changes
Dec 6, 2017
jwhitlock
left a comment
Contributor
There was a problem hiding this comment.
This looks like it will work, and we can try it on the next stage push. Thanks, @escattone!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to prevent a pitfall, when pushing to stage and production, that occurs when the image specified by the tag determined from the latest commit hash was not successfully pushed to the Docker image registry. The deployment succeeds, but the pods affected by the deployment loop in an image-pull error. This PR prevents that. I wanted to put this in place before we create the
prod-pushbranch.