Add text-decoration-line CSS example#487
Conversation
wbamberg
left a comment
There was a problem hiding this comment.
This looks great, and I agree about omitting blink. But is there a reason you didn't include a choice with multiple values, like underline overline? We have space for two more choices.
|
Nope, just thought to keep it simple but you're right, they do belong in there. I committed and squashed over my original commit. I didn't use more than 2 keywords because I got a horizontal scrollbar at 720px width (shown below), let me know if you'd like to demonstrate it anyways.
|
wbamberg
left a comment
There was a problem hiding this comment.
Looks great, thanks for the update @danielhickman ! I think it is worth showing the 2-value syntax, since it's not obvious that this is supported.
I agree with your judgement on the 3-value syntax. It's OK having a horizontal scrollbar, IMO, but it's not ideal, and in this case it doesn't seem to add much illustrative power over the 2-value syntax.
Fixes: #477 reusing some code from
text-decoration. Didn't include deprecatedblinkand setunderlineas the default.