Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Add <angle> example#473

Merged
wbamberg merged 3 commits into
mdn:masterfrom
mfluehr:angle
Jan 26, 2018
Merged

Add <angle> example#473
wbamberg merged 3 commits into
mdn:masterfrom
mfluehr:angle

Conversation

@mfluehr

@mfluehr mfluehr commented Jan 26, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@wbamberg wbamberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another great-looking example. Only comment: should we make the title "CSS Demo: <angle>", to match the page title?

Comment thread site.json Outdated
"../../live-examples/css-examples/css/angle.css",
"exampleCode": "live-examples/css-examples/angle.html",
"fileName": "angle.html",
"title": "CSS Demo: angle",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment I have is: should we make the title "CSS Demo: <angle>" to match the page title?

@wbamberg wbamberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mfluehr !

@wbamberg wbamberg merged commit 02f46bf into mdn:master Jan 26, 2018
@mfluehr mfluehr deleted the angle branch January 26, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants