Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Enhance formatObject to support formatting actual object#451

Merged
schalkneethling merged 2 commits into
mdn:masterfrom
kenrick95:master
Jan 24, 2018
Merged

Enhance formatObject to support formatting actual object#451
schalkneethling merged 2 commits into
mdn:masterfrom
kenrick95:master

Conversation

@kenrick95

Copy link
Copy Markdown
Contributor

Fixes #442

@welcome

welcome Bot commented Jan 23, 2018

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@schalkneethling

Copy link
Copy Markdown

@kenrick95 Thanks so much for your contribution, and adding tests 🎉 🍰 - I am going to do some additional manual tests locally, in the mean time I see there is one conflict which needs to be resolved. Thanks again

@schalkneethling schalkneethling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Nit that needs to be fixed. Please use single quotes instead of double quotes.

@kenrick95

Copy link
Copy Markdown
Contributor Author

Alright, code formatting issues fixed and conflicts resolved (hopefully correctly)! Thanks for reviewing 😁

@schalkneethling schalkneethling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Thanks @kenrick95

@schalkneethling schalkneethling merged commit ece08a5 into mdn:master Jan 24, 2018
@welcome

welcome Bot commented Jan 24, 2018

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants