This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Disables interactive examples for the currently disabled SharedArrayBuffer#430
Merged
wbamberg merged 1 commit intoJan 20, 2018
Merged
Disables interactive examples for the currently disabled SharedArrayBuffer#430wbamberg merged 1 commit into
wbamberg merged 1 commit into
Conversation
wbamberg
approved these changes
Jan 20, 2018
wbamberg
left a comment
Contributor
There was a problem hiding this comment.
I agree, let's disable it. Thanks @schalkneethling !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wbamberg This uses the
featureDetectorto disableSharedArrayBufferinteractive examples. Currently this is disabled because of Spectre. There is a message about it on the relevant pages. These examples will start working again once browser vendors have resolved the Spectre issue.Is this worth doing, or do you feel like we should keep the live examples? Currently clicking run will result in a message of:
Error: SharedArrayBuffer is not defined